Add --run-only-shellonly option to js/src/tests/jstests.py test harness

RESOLVED WONTFIX

Status

()

Core
JavaScript Engine
RESOLVED WONTFIX
4 years ago
2 years ago

People

(Reporter: jorendorff, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
I think we should run the subset of js/src/tests that are shell-only on tbpl on every build. I guess the first step would be having a jstests.py option that selects those tests.

Just to be clear: I'm doing this because I think there are a bunch of shell tests that we never run on tbpl.

I'm not sure of this. I asked on #ateam and got some clues:

<AutomatedTester> jorendorff: I think
http://mxr.mozilla.org/build/source/mozharness/configs/unittests/win_unittest.py#91
are the args passed in for testing

<AutomatedTester> jorendorff:
http://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla-tests/config.py#l388
calls
http://mxr.mozilla.org/build/source/mozharness/scripts/desktop_unittest.py#54
which calls
http://mxr.mozilla.org/build/source/mozharness/configs/unittests/win_unittest.py#91

<AutomatedTester> if I followed the rabbit hole properly :)

I don't know who, if anyone, can tell me if we already run shell js/src/tests or not.
(Reporter)

Comment 1

4 years ago
terrence and billm are very sure that we never run shell jstests on tbpl. On the other hand:

<Waldo> jorendorff: we run js/src/tests in the shell on tbpl in the &noignore=1 tree, I think

Another fix for the problem would be to look at each shell-only test (I think there are <100 of them) and see if it could run in the browser (SpecialPowers may provide the needed oomph) and if not just move it to js/src/jit-test/tests.
as we're now running jstests on treeherder, the option should be unnecessary.
maybe WONTFIX?
(Reporter)

Comment 3

2 years ago
OK.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.