103260 - Unable to change default email client preference from Messenger.

Status: VERIFIED FIXED

(MailNews Core :: Simple MAPI, defect, P1)

Description

[Trix Supremo]

If you attempt to change the preference setting from within Messenger, that
setting will fail to change.  But if you attempt to change the preference
setting from the browser, the change is saved.

1. Launch Browser.
2. Select Mozilla to be the default email client in Edit|Preferences|Mail &
Newsgroups.
3. Close and reopen pref panel to verify preference was saved.
4. Open Messenger.
5. Now unselect Mozilla mail to be the default email client from Messenger.
6. Close and reopen Messenger's pref panel.

ACTUAL:
The pref change was not changed and remains checked.

Comment 1

[lchiang]

I just ran into this.  I think it'll be hard for the user to figure out that
s/he has to go to the browser window to change this preference.  Nominate nsbranch.

Comment 2

[lchiang]

Actually, I just went to the browser (mail window was still open though) and
brought up the Preferences dialog.  I checked the box to use Netscape as the
default mail client.  Click OK.  Open the Preferences dlg again.  Change is not
retained.

2001-10-05 0.9.4 branch.  WinNT 4.0.

Comment 3

[lchiang]

Interesting.  It works now from the browser after a restart.

Comment 4

[Srilatha Moturi]

I looked into this little bit more and I think this is happening because we are 
getting a javascript error
JavaScript error:
chrome://messenger/content/pref-mailnewsOverlay.js line 23: parent.hPrefWindow 
has no properties.
I get this error only when the preferences dialog is launched from messenger.
but not when it is launched from browser.
I'm looking into this right now.

Comment 5

[Tiantian Kong]

Will fix it.

Comment 6

[Srilatha Moturi]

Attachment: patch v1

Comment 7

[Srilatha Moturi]

The problem is when preferences window is launched from messenger, hPrefWindow 
is not initailized by the time Init() gets called. SO I moved the 
registerOKCallbackFunc to startup.
Rajiv anc you review the path
Seth can you do the sr

Comment 8

[(not reading, please use [e-mail] instead)]

why do you need a new attribute on the check box?

why not just move this line:

+ parent.hPrefWindow.registerOKCallbackFunc( onOK );

into mailnewsOverlayInit()?

Comment 9

[(not reading, please use [e-mail] instead)]

over aim, srilatha explained to me that the initFunc is evaluated too early, so 
doing what I suggest would not work.

sr=sspitzer

Comment 10

[Jaime Rodriguez, Jr.]

pls check this into the branch - PDT+ 

Comment 11

[Srilatha Moturi]

Fix checked into the 0.9.4 branch

Comment 12

[Tiantian Kong]

Fixed in 0.9.4 branch.

Comment 13

[Trix Supremo]

verified on 2001-10-12-05-0.9.4

Comment 14

[Rajiv Dayal]

The patch here needs to be checked into the trunk along with MAPI trunk landing.
Seth can u please sr this for the trunk ?
thanks,  - Rajiv.

Comment 15

[Dave Musser]

I don't know what build this was fixed on, but I just downloaded build
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.7+) Gecko/20020108 and
though the default mail client box stays checked now, it does not change it in
the registry.  I still show netscape communicators messenger (4.0) as my default
mail client.  And windows still brings up the Netscape 4.0 messenger as the
default mail application.

Windows 2000 pro with latest critical updates and service pack 2.

Comment 16

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1532/files

Comment 17

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8448433 [details]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1532/files

oops, meant for bug 1032606