1032631 - [Settings] EU roaming APN support

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

This feature only gets enabled for devices sold in EU that are roaming within EU networks

- Enable the feature for matched mcc/mnc networks.
- Users should be provided with the EU roaming APN when the device is roaming to matched networks.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: WIP

The feature is for displaying a EU roaming notification when roaming to a specified EU operator with a specified EU sim card. I fake the list so the patch can be tested with a CHT sim card.

As this patch is based on the APN UX refresh patch which is not landed yet, I included the patch of APN in this one. Please check this commit only: https://github.com/crh0716/gaia/commit/d32e71b65ee7fd6bbb0b7f08263a3801735a4cf5

Please let me know if you need further explanation, thanks!

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8475818 [details]
WIP

I don't have the know-how but basically looks fine.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8475818 [details]
WIP

Left some comments on gitub, thanks the hard works, Arthur !

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8475818 [details]
WIP

Comments addressed and unit tests added. Please help check the patch again, thanks!

EJ, I'll start writing tests for ApnSettingsManager once the patch of APN UX refresh lands.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8475818 [details]
WIP

r+ with nits
* We don't want return in the start()
* Use MockSIMSlotManager

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: eu_roaming.png

Hi Helen, could you help provide an icon for the EU roaming notification? Thanks!

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8475818 [details]
WIP

Thanks Arthur, just few nits on Github ! 

r+.

Comment 8

[Kai-Chih Hu [:khu]]

Confirmed with EPM/EM, and this can be landed before FL.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for reviewing guys.

master: 3241439344aa9e6027402e07da42bd3935003e49

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Let's track the icon thing using bug 1061042.