Closed Bug 1032631 Opened 6 years ago Closed 6 years ago

[Settings] EU roaming APN support

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(feature-b2g:2.1)

RESOLVED FIXED
2.1 S3 (29aug)
feature-b2g 2.1

People

(Reporter: arthurcc, Assigned: arthurcc)

References

Details

(Whiteboard: [p=3])

Attachments

(2 files)

This feature only gets enabled for devices sold in EU that are roaming within EU networks

- Enable the feature for matched mcc/mnc networks.
- Users should be provided with the EU roaming APN when the device is roaming to matched networks.
See Also: → 1024776
Blocks: 1024776
feature-b2g: --- → 2.1
Assignee: nobody → arthur.chen
Target Milestone: --- → 2.1 S3 (29aug)
Status: NEW → ASSIGNED
Whiteboard: [p=3]
Attached file WIP
The feature is for displaying a EU roaming notification when roaming to a specified EU operator with a specified EU sim card. I fake the list so the patch can be tested with a CHT sim card.

As this patch is based on the APN UX refresh patch which is not landed yet, I included the patch of APN in this one. Please check this commit only: https://github.com/crh0716/gaia/commit/d32e71b65ee7fd6bbb0b7f08263a3801735a4cf5

Please let me know if you need further explanation, thanks!
Attachment #8475818 - Flags: feedback?(ejchen)
Attachment #8475818 - Flags: feedback?(alive)
Comment on attachment 8475818 [details]
WIP

I don't have the know-how but basically looks fine.
Attachment #8475818 - Flags: feedback?(alive) → feedback+
Comment on attachment 8475818 [details]
WIP

Left some comments on gitub, thanks the hard works, Arthur !
Attachment #8475818 - Flags: feedback?(ejchen) → feedback+
Comment on attachment 8475818 [details]
WIP

Comments addressed and unit tests added. Please help check the patch again, thanks!

EJ, I'll start writing tests for ApnSettingsManager once the patch of APN UX refresh lands.
Attachment #8475818 - Flags: review?(ejchen)
Attachment #8475818 - Flags: review?(alive)
Comment on attachment 8475818 [details]
WIP

r+ with nits
* We don't want return in the start()
* Use MockSIMSlotManager
Attachment #8475818 - Flags: review?(alive) → review+
Attached image eu_roaming.png
Hi Helen, could you help provide an icon for the EU roaming notification? Thanks!
Flags: needinfo?(hhuang)
Comment on attachment 8475818 [details]
WIP

Thanks Arthur, just few nits on Github ! 

r+.
Attachment #8475818 - Flags: review?(ejchen) → review+
Confirmed with EPM/EM, and this can be landed before FL.
Thanks for reviewing guys.

master: 3241439344aa9e6027402e07da42bd3935003e49
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Let's track the icon thing using bug 1061042.
Flags: needinfo?(hhuang)
You need to log in before you can comment on or make changes to this bug.