Closed Bug 1032631 Opened 6 years ago Closed 6 years ago
[Settings] EU roaming APN support
This feature only gets enabled for devices sold in EU that are roaming within EU networks - Enable the feature for matched mcc/mnc networks. - Users should be provided with the EU roaming APN when the device is roaming to matched networks.
Status: NEW → ASSIGNED
The feature is for displaying a EU roaming notification when roaming to a specified EU operator with a specified EU sim card. I fake the list so the patch can be tested with a CHT sim card. As this patch is based on the APN UX refresh patch which is not landed yet, I included the patch of APN in this one. Please check this commit only: https://github.com/crh0716/gaia/commit/d32e71b65ee7fd6bbb0b7f08263a3801735a4cf5 Please let me know if you need further explanation, thanks!
Comment on attachment 8475818 [details] WIP I don't have the know-how but basically looks fine.
Attachment #8475818 - Flags: feedback?(alive) → feedback+
Comment on attachment 8475818 [details] WIP Left some comments on gitub, thanks the hard works, Arthur !
Attachment #8475818 - Flags: feedback?(ejchen) → feedback+
Comment on attachment 8475818 [details] WIP Comments addressed and unit tests added. Please help check the patch again, thanks! EJ, I'll start writing tests for ApnSettingsManager once the patch of APN UX refresh lands.
Comment on attachment 8475818 [details] WIP r+ with nits * We don't want return in the start() * Use MockSIMSlotManager
Attachment #8475818 - Flags: review?(alive) → review+
Hi Helen, could you help provide an icon for the EU roaming notification? Thanks!
Comment on attachment 8475818 [details] WIP Thanks Arthur, just few nits on Github ! r+.
Attachment #8475818 - Flags: review?(ejchen) → review+
Confirmed with EPM/EM, and this can be landed before FL.
Thanks for reviewing guys. master: 3241439344aa9e6027402e07da42bd3935003e49
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Let's track the icon thing using bug 1061042.
You need to log in before you can comment on or make changes to this bug.