Closed
Bug 1032640
Opened 10 years ago
Closed 9 years ago
MSVC warnings in webrtc/signaling about C4273: '_stricmp' : inconsistent dll linkage
Categories
(Core :: WebRTC: Signaling, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
Tracking | Status | |
---|---|---|
firefox33 | --- | affected |
People
(Reporter: cpeterson, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.56 KB,
patch
|
ehugg
:
review+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=42816626&tree=Mozilla-Central&full=1 c:\builds\moz2_slave\m-cen-w32-d-000000000000000000\build\media\webrtc\signaling\src\sipcc\cpr\include\cpr_strings.h(39) : warning C4273: '_stricmp' : inconsistent dll linkage c:\PROGRA~2\MICROS~2.0\vc\include\string.h(142) : see previous definition of '_stricmp' c:\builds\moz2_slave\m-cen-w32-d-000000000000000000\build\media\webrtc\signaling\src\sipcc\cpr\include\cpr_strings.h(55) : warning C4273: '_strnicmp' : inconsistent dll linkage c:\PROGRA~2\MICROS~2.0\vc\include\string.h(182) : see previous definition of '_strnicmp'
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Here's a patch to straighten things out. The setup here is really weird, so a long explanation: 1. We set CPR_USE_OS_STRCASECMP to stop the prototyping of the functions. 2. We include #ifndef checks in cpr_strings.h to avoid macro redefinition warnings. 3. We delete the str*casecmp definitions in cpr_win_string.c because they were completely unused. All of these could use some cleanup, I think, since the wrapper functions everywhere look less efficient than they could be...
Attachment #8494629 -
Flags: review?(rjesup)
Comment 2•9 years ago
|
||
Comment on attachment 8494629 [details] [diff] [review] eliminate dll linkage warnings lgtm, but passing by ehugg just in case
Attachment #8494629 -
Flags: review?(rjesup) → review?(ethanhugg)
Comment 3•9 years ago
|
||
Comment on attachment 8494629 [details] [diff] [review] eliminate dll linkage warnings Review of attachment 8494629 [details] [diff] [review]: ----------------------------------------------------------------- This looks fine. Much of this code will be removed when Unicorn, the new SDP handling lands.
Attachment #8494629 -
Flags: review?(ethanhugg) → review+
![]() |
Assignee | |
Updated•9 years ago
|
Assignee: nobody → nfroyd
![]() |
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d75cac1f3eb3
Flags: in-testsuite-
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d75cac1f3eb3
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•9 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•