1032640 - MSVC warnings in webrtc/signaling about C4273: '_stricmp' : inconsistent dll linkage

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Chris Peterson [:cpeterson]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=42816626&tree=Mozilla-Central&full=1

c:\builds\moz2_slave\m-cen-w32-d-000000000000000000\build\media\webrtc\signaling\src\sipcc\cpr\include\cpr_strings.h(39) : warning C4273: '_stricmp' : inconsistent dll linkage
        c:\PROGRA~2\MICROS~2.0\vc\include\string.h(142) : see previous definition of '_stricmp'

c:\builds\moz2_slave\m-cen-w32-d-000000000000000000\build\media\webrtc\signaling\src\sipcc\cpr\include\cpr_strings.h(55) : warning C4273: '_strnicmp' : inconsistent dll linkage
        c:\PROGRA~2\MICROS~2.0\vc\include\string.h(182) : see previous definition of '_strnicmp'

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: eliminate dll linkage warnings

Here's a patch to straighten things out.  The setup here is really weird, so a long explanation:

1. We set CPR_USE_OS_STRCASECMP to stop the prototyping of the functions.
2. We include #ifndef checks in cpr_strings.h to avoid macro redefinition warnings.
3. We delete the str*casecmp definitions in cpr_win_string.c because they were completely unused.

All of these could use some cleanup, I think, since the wrapper functions everywhere look less efficient than they could be...

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8494629 [details] [diff] [review]
eliminate dll linkage warnings

lgtm, but passing by ehugg just in case

Comment 3

[Ethan Hugg [:ehugg]]

Comment on attachment 8494629 [details] [diff] [review]
eliminate dll linkage warnings

Review of attachment 8494629 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine.  Much of this code will be removed when Unicorn, the new SDP handling lands.

Comment 4

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d75cac1f3eb3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d75cac1f3eb3