1032754 - use the generic font-family:sans-serif in Gaia CSS rather than explicitly naming "Fira Sans"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Jonathan Kew [:jfkthame]]

In a few places, Gaia CSS currently has

  font-family: 'Fira Sans', sans-serif;

This is unnecessary, as sans-serif will resolve to Fira Sans on FirefoxOS anyhow; and until bug 987872, it was wrong anyhow, as the family name was "Fira Sans OT", so plain "Fira Sans" would not be found.

We should simply use font-family:sans-serif, and rely on the system's preference settings to resolve this to the proper sans-serif font family.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: [PR] remove explicit use of 'Fira Sans' in favor of generic sans-serif

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8448646 [details] [review]
[PR] remove explicit use of 'Fira Sans' in favor of generic sans-serif

Thanks!

Comment 3

[Carsten Book [:Tomcat]]

Hi Jonathan, do need a try run for that, if so could you provide a try link, thanks ? (also note the travis build failed it seems https://travis-ci.org/mozilla-b2g/gaia/builds/28859150)

Comment 4

[Jonathan Kew [:jfkthame]]

(In reply to Carsten Book [:Tomcat] from comment #3)
> Hi Jonathan, do need a try run for that, if so could you provide a try link,
> thanks ? (also note the travis build failed it seems
> https://travis-ci.org/mozilla-b2g/gaia/builds/28859150)

I don't see any plausible reason this would cause failures, but I tried pushing a try job just in case:
https://tbpl.mozilla.org/?tree=Try&rev=de4211226187

(Hope I did that right; I'm not really familiar with testing Gaia stuff.)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing before it can be merged.

Comment 6

[Jonathan Kew [:jfkthame]]

Rebased PR to upstream/master.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/30bf079c895fe59a1af06494423ac0709e5b90c5