1032789 - GCLI should pull together the various plugin points into a 'system' so we know what needs what

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Joe Walker [:jwalker]]

Currently commands and types are encapsulated in objects, but the registered converters are stored at the module level. Better if all pluggable things are stored in objects in the same way.
This will make the client/server switch easier (bug 1032785).

Comment 1

[Joe Walker [:jwalker]]

Attachment: 0001-Bug-1032789-Pull-together-the-various-GCLI-plugin-po.patch

Refactoring patch for GCLI.

In essence it takes the various plug-in points and unifies the way they work. There is one manager class for each of them now, and there is a single object that points to them all, called 'system'. Not complex just churn.

The easiest place to follow the changes is probably here: https://github.com/joewalker/gcli/pull/74
I merged those changes into the mozilla branch here: https://github.com/mozilla/gcli/pull/19 but that's got separate merge commits, so everything appears twice.

Probably the best review strategy is to read the change descriptions in the first pull request and then look on splinter.

Comment 2

[Joe Walker [:jwalker]]

Green try push: https://tbpl.mozilla.org/?tree=Try&rev=3a35e2d856e9

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8451594 [details] [diff] [review]
0001-Bug-1032789-Pull-together-the-various-GCLI-plugin-po.patch

Review of attachment 8451594 [details] [diff] [review]:
-----------------------------------------------------------------

I really like this patch, r+.

Comment 4

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=d5733ac865af
https://hg.mozilla.org/integration/fx-team/rev/ed3d46b267f5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ed3d46b267f5