Make B2GDesktop Mulet-ready

RESOLVED FIXED in 2.0 S5 (4july)

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gerard-majax, Assigned: gerard-majax)

Tracking

unspecified
2.0 S5 (4july)
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
In bug 1030679 we want Gaia UI tests to be ran against Mulet. After investigating this, we need to hack GeckoInstance from marionette_client package and add the -chrome command line arguments.

Once this is done, we can run those tests against this build.
(Assignee)

Comment 1

5 years ago
Created attachment 8448824 [details] [diff] [review]
0001-Bug-1032799-Pass-chrome-argument-to-B2G-Desktop.patch

Please find attached a patch that does the job. It works on my local system, but before asking for review, I'd like a feedback:
 - are you okay with the way it's done
 - is there any tests I should update (I found none when searching)
 - is there any try I should run ?

Thanks!
Attachment #8448824 - Flags: feedback?(jgriffin)
Attachment #8448824 - Flags: feedback?(dave.hunt)
Does this break compatibility with the existing B2G desktop build runs?  If not, it's probably ok.

There aren't any unit tests of this code that need to be updated.

You should run this through try with syntax:  -b o -p linux64_gecko -u all -t none
Comment on attachment 8448824 [details] [diff] [review]
0001-Bug-1032799-Pass-chrome-argument-to-B2G-Desktop.patch

Review of attachment 8448824 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/geckoinstance.py
@@ +79,5 @@
>  class B2GDesktopInstance(GeckoInstance):
>      required_prefs = {"focusmanager.testmode": True}
>  
> +    def __init__(self, **kwargs):
> +        GeckoInstance.__init__(self, **kwargs)

The preferred way to do this is:

super(B2GDesktopInstance, self).__init__(**kwargs)
(Assignee)

Comment 4

5 years ago
(In reply to Jonathan Griffin (:jgriffin) from comment #2)
> Does this break compatibility with the existing B2G desktop build runs?  If
> not, it's probably ok.
> 
> There aren't any unit tests of this code that need to be updated.
> 
> You should run this through try with syntax:  -b o -p linux64_gecko -u all
> -t none

No, there should be no compatibility breakage :).
(Assignee)

Comment 5

5 years ago
Created attachment 8449248 [details] [diff] [review]
0001-Bug-1032799-Pass-chrome-argument-to-B2G-Desktop.patch

Initializing the parent class via super(). I'll toggle the review once Try is green.
Attachment #8448824 - Attachment is obsolete: true
Attachment #8448824 - Flags: feedback?(jgriffin)
Attachment #8448824 - Flags: feedback?(dave.hunt)
(Assignee)

Comment 7

5 years ago
Comment on attachment 8449248 [details] [diff] [review]
0001-Bug-1032799-Pass-chrome-argument-to-B2G-Desktop.patch

Okay, try is green: https://tbpl.mozilla.org/?tree=Try&rev=a2b2e3ea1880
Attachment #8449248 - Flags: review?(jgriffin)
Comment on attachment 8449248 [details] [diff] [review]
0001-Bug-1032799-Pass-chrome-argument-to-B2G-Desktop.patch

Review of attachment 8449248 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8449248 - Flags: review?(jgriffin) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 9

5 years ago
Jonathan, don't we need to push version and release a new python package.
Flags: needinfo?(jgriffin)
(In reply to Alexandre LISSY :gerard-majax from comment #9)
> Jonathan, don't we need to push version and release a new python package.

No, TBPL uses in-tree Marionette; only extra-tree harnesses need Python packages, and none of those need to support Mulet yet.  We'll pick this up the next time we release a Python package for other reasons.
Flags: needinfo?(jgriffin)
https://hg.mozilla.org/mozilla-central/rev/64d49532fea3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Whiteboard: [systemsfe]
Target Milestone: mozilla33 → 2.0 S5 (4july)
You need to log in before you can comment on or make changes to this bug.