Closed
Bug 1032863
Opened 11 years ago
Closed 11 years ago
RID tracking is broken when logging in via new Angular modal
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: adam, Assigned: cade)
References
Details
(Whiteboard: [metrics] [July25])
Attachments
(1 file, 1 obsolete file)
The new Angular pages use a new modal window for creating a new user account, and not the default one built into webmaker-auth-client.
The logic that saves a RID to a new user account is not replicated in this alternative modal, so new accounts created via the new pages will not get RIDs applied to them.
This is where the ref ID gets passed to login.webmaker.org in the default modal:
https://github.com/mozilla/webmaker-auth-client/blob/master/webmaker-auth-client.js#L182
We're now using RIDs for real tracking (e.g. snippet and Maker Party partners) so it would be good to fix this as soon as we can.
Updated•11 years ago
|
Assignee: kate → jon
Updated•11 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [July11] → [metrics] [July11]
Reporter | ||
Comment 1•11 years ago
|
||
Is this still planned for today? I noticed the angular login modal has rolled out to more pages now so we're missing a bit more data.
Updated•11 years ago
|
Whiteboard: [metrics] [July11] → [metrics] [July25]
Assignee | ||
Updated•11 years ago
|
Assignee: jon → cade
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8455618 -
Flags: review?(jon)
Comment 3•11 years ago
|
||
Comment on attachment 8455618 [details] [review]
https://github.com/mozilla/webmaker.org/pull/870
This is a good fix for webmaker.org, but we should fix it for all pages using angular by editing https://github.com/mozilla/webmaker-auth-client/blob/master/webmaker-auth-client.js#L289 to include the cookieRefValue directly.
Attachment #8455618 -
Flags: review?(jon) → review-
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8456144 -
Flags: review?(jon)
Updated•11 years ago
|
Attachment #8455618 -
Attachment is obsolete: true
Updated•11 years ago
|
Attachment #8456144 -
Flags: review?(jon) → review+
Comment 5•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker-auth-client
https://github.com/mozilla/webmaker-auth-client/commit/e4b200423a4706f6891875b0c8a5f5f27d810902
Bug 1032863 - Apply the Webmaker RID withing the createUser function
Comment 6•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/643ed63414235481cc8f87f4bfcff594ada06eb8
Bug 1032863 - Update webmaker-auth-client and newrelic
Comment 7•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/login.webmaker.org
https://github.com/mozilla/login.webmaker.org/commit/9df46bbf7f792239d9b16bbdaf5077fbcfed5f92
Bug 1032863 - Update newrelic and webmaker-auth-client
Comment 8•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker-events-2
https://github.com/mozilla/webmaker-events-2/commit/6495c7edc23d6717515fe058495a7e033cae1451
Bug 1032863 - Update newrelic and webmaker-auth-client
Comment 9•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker-events-service
https://github.com/mozilla/webmaker-events-service/commit/f249390257c385fc9bc0b729232e77be41395d31
Bug 1032863 - update newrelic package to 1.8.0
Comment 10•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/goggles.webmaker.org
https://github.com/mozilla/goggles.webmaker.org/commit/0da28b32c6793e73d98d504fac0e00319d479ea7
Bug 1032863 - Update webmaker-auth-client to v1.1.10
Comment 11•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org
https://github.com/mozilla/thimble.webmaker.org/commit/8b26bdad2eb48df9fa1018ed73a5d66a3aeb496f
Bug 1032863 - Update webmaker-auth client to v0.1.10
Comment 12•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org
https://github.com/mozilla/popcorn.webmaker.org/commit/fc50396a757c9b448a08abd2f07121e061aff86d
Bug 1032863 - Update webmaker-auth-client to v0.1.10
Comment 13•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker-profile-2
https://github.com/mozilla/webmaker-profile-2/commit/895c351b352bc819f63a2213d72984cc8b7fd8aa
bug 1032863 - Update webmaker-auth-client to v0.1.10
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 14•11 years ago
|
||
appmaker's update over at https://github.com/mozilla-appmaker/appmaker/pull/1865 fails Travis, as well as local dev npm install, so reopened for the moment, some more fixes required.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 15•11 years ago
|
||
(In reply to Mike "Pomax" Kamermans [:pomax] from comment #14)
> appmaker's update over at
> https://github.com/mozilla-appmaker/appmaker/pull/1865 fails Travis, as well
> as local dev npm install, so reopened for the moment, some more fixes
> required.
It was a weird network problem with the webmaker-download-locales script that seems to have fixed itself. I also realized that appmaker commits bower modules, so I did that too
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•