1032863 - RID tracking is broken when logging in via new Angular modal

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Adam Lofting (:adamlofting)]

The new Angular pages use a new modal window for creating a new user account, and not the default one built into webmaker-auth-client.

The logic that saves a RID to a new user account is not replicated in this alternative modal, so new accounts created via the new pages will not get RIDs applied to them.

This is where the ref ID gets passed to login.webmaker.org in the default modal:
https://github.com/mozilla/webmaker-auth-client/blob/master/webmaker-auth-client.js#L182

We're now using RIDs for real tracking (e.g. snippet and Maker Party partners) so it would be good to fix this as soon as we can.

Comment 1

[Adam Lofting (:adamlofting)]

Is this still planned for today? I noticed the angular login modal has rolled out to more pages now so we're missing a bit more data.

Comment 2

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker.org/pull/870

Comment 3

[Jon Buckley [:jbuck]]

Comment on attachment 8455618 [details] [review]
https://github.com/mozilla/webmaker.org/pull/870

This is a good fix for webmaker.org, but we should fix it for all pages using angular by editing https://github.com/mozilla/webmaker-auth-client/blob/master/webmaker-auth-client.js#L289 to include the cookieRefValue directly.

Comment 4

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker-auth-client/pull/32

https://github.com/mozilla/webmaker-auth-client/pull/32

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-auth-client

https://github.com/mozilla/webmaker-auth-client/commit/e4b200423a4706f6891875b0c8a5f5f27d810902
Bug 1032863 - Apply the Webmaker RID withing the createUser function

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/643ed63414235481cc8f87f4bfcff594ada06eb8
Bug 1032863 - Update webmaker-auth-client and newrelic

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/9df46bbf7f792239d9b16bbdaf5077fbcfed5f92
Bug 1032863 - Update newrelic and webmaker-auth-client

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-events-2

https://github.com/mozilla/webmaker-events-2/commit/6495c7edc23d6717515fe058495a7e033cae1451
Bug 1032863 - Update newrelic and webmaker-auth-client

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-events-service

https://github.com/mozilla/webmaker-events-service/commit/f249390257c385fc9bc0b729232e77be41395d31
Bug 1032863 - update newrelic package to 1.8.0

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/goggles.webmaker.org

https://github.com/mozilla/goggles.webmaker.org/commit/0da28b32c6793e73d98d504fac0e00319d479ea7
Bug 1032863 - Update webmaker-auth-client to v1.1.10

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/8b26bdad2eb48df9fa1018ed73a5d66a3aeb496f
Bug 1032863 - Update webmaker-auth client to v0.1.10

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/fc50396a757c9b448a08abd2f07121e061aff86d
Bug 1032863 - Update webmaker-auth-client to v0.1.10

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-profile-2

https://github.com/mozilla/webmaker-profile-2/commit/895c351b352bc819f63a2213d72984cc8b7fd8aa
bug 1032863 - Update webmaker-auth-client to v0.1.10

Comment 14

[Pomax]

appmaker's update over at https://github.com/mozilla-appmaker/appmaker/pull/1865 fails Travis, as well as local dev npm install, so reopened for the moment, some more fixes required.

Comment 15

[Chris DeCairos (:cade)]

(In reply to Mike "Pomax" Kamermans [:pomax] from comment #14)
> appmaker's update over at
> https://github.com/mozilla-appmaker/appmaker/pull/1865 fails Travis, as well
> as local dev npm install, so reopened for the moment, some more fixes
> required.

It was a weird network problem with the webmaker-download-locales script that seems to have fixed itself. I also realized that appmaker commits bower modules, so I did that too