Closed Bug 1032885 Opened 5 years ago Closed 5 years ago

Prevent the permission prompt dialog to steal the focus

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

defect
Not set

Tracking

(blocking-b2g:2.0+, b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S5 (4july)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

While debugging bug 1030700 and looking more specifically about the permission dialog since some of the comments seems to says that this is important, I found that the select is close/denied if the permission prompt appears on top of the dialog and the user do anything.

This is because the focus is lost while the user touch the permission prompt dialog, and then the <select> is close returning |false| to the homescreen and corrupting the pendingIds list as described in bug 1032829.


This is a recent issue introduced by the cache mechanism introduced recently in order to make the collection starts faster.
Attached patch bug1032885.patchSplinter Review
Kevin, it was not happening before because the list was not displayed until the geolocation is resolved.
Assignee: nobody → 21
Status: NEW → ASSIGNED
Attachment #8448785 - Flags: review?(kgrandon)
Whiteboard: [systemsfe]
Comment on attachment 8448785 [details] [diff] [review]
bug1032885.patch

Review of attachment 8448785 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, this definitely fixes the collections problem.
Attachment #8448785 - Flags: review?(kgrandon) → review+
Blocks: 1030700
(This should block, it blocks a blocker)
blocking-b2g: 2.0? → 2.0+
QA Whiteboard: [VH-FL-blocking+][VH-FC-blocking+]
QA Whiteboard: [VH-FL-blocking+][VH-FC-blocking+] → [VH-FL-blocking-][VH-FC-blocking+]
Target Milestone: --- → 2.0 S5 (4july)
You need to log in before you can comment on or make changes to this bug.