1032885 - Prevent the permission prompt dialog to steal the focus

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

While debugging bug 1030700 and looking more specifically about the permission dialog since some of the comments seems to says that this is important, I found that the select is close/denied if the permission prompt appears on top of the dialog and the user do anything.

This is because the focus is lost while the user touch the permission prompt dialog, and then the <select> is close returning |false| to the homescreen and corrupting the pendingIds list as described in bug 1032829.


This is a recent issue introduced by the cache mechanism introduced recently in order to make the collection starts faster.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug1032885.patch

Kevin, it was not happening before because the list was not displayed until the geolocation is resolved.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8448785 [details] [diff] [review]
bug1032885.patch

Review of attachment 8448785 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, this definitely fixes the collections problem.

Comment 3

[Kevin Grandon :kgrandon]

(This should block, it blocks a blocker)

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/fe70a38bc871dd033724394b0378a40ffdd66e14

Comment 5

[Kevin Grandon :kgrandon]

2.0: https://github.com/mozilla-b2g/gaia/commit/98955263a0e376d8d41b1843b2dcc24108a4f5a0