Closed Bug 1032933 Opened 10 years ago Closed 10 years ago

[Search] Use closest icon size for marketplace results

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Search
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S5 (4july)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [p=2],[systemsfe])

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
crdlc
: review+
bajaj
: approval-gaia-v2.0+
Details | Review 
Now that we have a new API endpoint implemented in bug 1029635, we should take advantage of it in the search app for more crisp icons.
Attached file Github pull request — 

    
    

    
  
We should try to get this fixed, but I don't think we'll block on this.
Blocks: vertical-home-next
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]

    
    

    
  
Comment on attachment 8448856 [details] [review]
Github pull request

Hey guys - anyone have time for a quick review? Mostly just moving the _icon method from Mozapp for reuse. Let me know what you think.

        Attachment #8448856 -
        Flags: review?(dale)

        Attachment #8448856 -
        Flags: review?(crdlc)

    
    

    
  
Comment on attachment 8448856 [details] [review]
Github pull request

LGTM Kevin, thanks

        Attachment #8448856 -
        Flags: review?(crdlc) → review+

    
    

    
  
Comment on attachment 8448856 [details] [review]
Github pull request

Thanks for the review! Dale feel free to leave any comments if you have them.

        Attachment #8448856 -
        Flags: review?(dale)

    
    

    
  
Landed: https://github.com/mozilla-b2g/gaia/commit/d0beeca2401ff90564dfcbe45ee5237d46605ab8
Blocks: vertical-homescreen
No longer blocks: vertical-home-next
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8448856 [details] [review]
Github pull request

The crisper icons that this patch providers is a much better experience for the vertical homescreen. Would like to uplift this one.

        Attachment #8448856 -
        Flags: approval-gaia-v2.0?(bbajaj)

        Attachment #8448856 -
        Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: