1032967 - [traceback] GengoError: language service not supported

Status: RESOLVED FIXED

(Input Graveyard :: Submission, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Getting these for a job to translate something from Greek (el) to English (en):

Traceback (most recent call last):
  File "/data/input/src/input.mozilla.org/input/vendor/src/django/django/core/management/base.py", line 222, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/data/input/src/input.mozilla.org/input/vendor/src/django/django/core/management/base.py", line 255, in execute
    output = self.handle(*args, **options)
  File "/data/input/src/input.mozilla.org/input/fjord/translations/management/commands/translation_sync.py", line 25, in handle
    system.push_translations()
  File "/data/input/src/input.mozilla.org/input/fjord/translations/models.py", line 552, in push_translations
    resp = gengo_api.human_translate_bulk(batch)
  File "/data/input/src/input.mozilla.org/input/fjord/translations/gengo_utils.py", line 72, in _requires_keys
    return fun(self, *args, **kwargs)
  File "/data/input/src/input.mozilla.org/input/fjord/translations/gengo_utils.py", line 283, in human_translate_bulk
    resp = self.gengo_api.postTranslationJobs(jobs=payload)
  File "/data/input/src/input.mozilla.org/input/vendor/src/gengo-python/gengo/gengo.py", line 293, in get
    next()[0]['code'])
GengoError: '<job_36: language service not supported> '


Need to fix that.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this now to work on.

getServiceLanguages says they handle Greek just fine, so that's not helpful.

GengoError is a generic exception thrown for any kind of error from the API endpoint, so that's not helpful.

There's an error code in GengoError. If it's throwing a specific error code that's specifically about this error, then I can handle it. Otherwise, I'm not entirely sure what to do short of maintaining a list of "known-bad languages".

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

They have another endpoint that returns valid pairs. I think I can use that to fix this:

http://developers.gengo.com/v2/api_methods/service/#language-pairs-get

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/318

Landed in master: https://github.com/mozilla/fjord/commit/74e8e09

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pushed to prod just now. I have to wait for the cron job to kick off before I know whether that fixed it, so I'm going to mark it FIXED now and reopen if there are issues.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was a P2 so as to stop the errors.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Oops--retro-actively made this 1 point. Pretty sure that's about how much work I did.

Comment 7

[Japanesetrans]

our website https://japanesetrans.com site menu not appear correctly on some times with Firefox