1032981 - [B2G][Clock]After pressing 'Stop' when an alarm goes off, the check mark does not disappear in the clock app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Andrew Stole [:astole]]

Attachment: logcat

When an Alarm that is set to never repeat goes off and the 'Stop' option is selected instead of snooze, the check mark stays on the alarm as if it is still set instead of it getting removed. The alarm does not go off again.

Repro Steps:
1) Update a Flame to BuildID: 20140701072955
2) Open the Clock app
3) Set an alarm
4) When the alarm goes off press 'Stop'
5) Open Clock app again

Actual:
Check mark is not removed from Alarm

Expected:
After pressing 'Stop' the check mark is removed from the Alarm

2.1 Environmental Variables:
Device: Flame 2.1
BuildID: 20140701072955
Gaia: 34a52e7f024cc3d0e3aade94970773d2555f5ccb
Gecko: ffb8b976548b
Version: 33.0a1
Firmware Version: v122

Repro frequency: 2/2, 100%
See attached: Video, logcat

Comment 1

[Andrew Stole [:astole]]

Attaching video and adding qawanted to check other devices and builds.

Comment 2

[Peter Bylenga [:PBylenga]]

Nominating to block, the visual active state (on) does not match the actual state of the alarm (off).  Also note this isn't a repeating alarm.

Comment 3

[Marcus Cavanaugh [:mcav]]

Please do not nominate issues to block 2.0 unless they have been confirmed affected in the v2.0 branch.

Testing locally, this does _not_ reproduce on v2.0, only on master. This bug appears to be a regression from bug 1001568. Investigating now.

Comment 4

[Peter Bylenga [:PBylenga]]

Understood, nominating to block 2.1, confirmed doesn't reproduce on 2.0. Regression, requesting a window.

Environmental Variables:
Device: Flame 2.0
Build ID: 20140701000201
Gaia: 8fb5e2a9ad1025ee7d247b90af7499766afadd28
Gecko: 5da69a493324
Version: 32.0a2 (2.0)
Firmware Version: v122

Comment 5

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21245

Comment 6

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8449018 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21245

LGTM!

Comment 7

[Marcus Cavanaugh [:mcav]]

master: https://github.com/mozilla-b2g/gaia/commit/52d8e1354ae5456a9c0cb30f9c365b74385e69fd

Clearing nom, as 2.1 === master.