1033010 - Prevent jquery datatable from overriding the initial sort order

Status: RESOLVED FIXED

(Webtools :: mediawiki-bugzilla, defect)

Description

[Ed Morley [:emorley]]

Filing this in bugzilla (original issue at: https://github.com/mozilla/mediawiki-bugzilla/issues/43) so I can set flags/track in my normal Bugzilla workflow.

glob wrote:
> if you provide an order parameter to a table, this isn't honoured in the table; it's always sorted by ID.
> 
> eg.
> 
> <bugzilla>
> {
> "keywords": "bmo-big bmo-goal",
> "keywords_type": "anywords",
> "priority": ["P1","P2","P3","P4","P5"],
> "include_fields": "id, priority, summary, status, resolution, assigned_to, keywords",
> "order": "keywords DESC, priority, bug_id"
> }
> </bugzilla>
> 
> the results are returned by bugzilla, and inserted into html in the correct order by the php plugin. they are then re-ordered by the jquery datatable, which i consider to be a bug.
> 
> as far as i can tell this can be fixed by setting aaSorting to an empty array when initialising dataTable

Comment 1

[Ed Morley [:emorley]]

Attachment: PR: Disable initial jquery datatable sort

This fixes issue #43, solution as suggested by http://stackoverflow.com/questions/4964388/is-there-a-way-to-disable-initial-sorting-for-jquery-datatables

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8448953 [details] [review]
PR: Disable initial jquery datatable sort

(Changed to patch=1 to appease bugzilla-todos, but that breaks the redirect)

Comment 3

[Ed Morley [:emorley]]

Christie, do you have an idea when you might be able to take a look at this? :-)

Comment 4

[Christie Koehler [:ckoehler]]

(In reply to Ed Morley [:edmorley] from comment #3)
> Christie, do you have an idea when you might be able to take a look at this?
> :-)

I don't, unfortunately. I'm backed up with a bunch of other tasks. 

Also, right now we don't have a way to test this without having WebOps apply directly to wiki-dev.allizom.org. 

Regular wiki working group meeting is next week and I will see if someone has time to review then.

Comment 5

[Ed Morley [:emorley]]

(In reply to Christie Koehler [:ckoehler] from comment #4)
> Also, right now we don't have a way to test this without having WebOps apply
> directly to wiki-dev.allizom.org. 

The patch is a one line change that just adds a new pref to the page inline JS. Given it only affects the UI, would you object to me working with IT to try rolling it out, and rolling back minutes later if it doesn't work?

Comment 6

[Christie Koehler [:ckoehler]]

(In reply to Ed Morley [:edmorley] from comment #5)
> The patch is a one line change that just adds a new pref to the page inline
> JS. Given it only affects the UI, would you object to me working with IT to
> try rolling it out, and rolling back minutes later if it doesn't work?

No objections. Thanks for taking that on!

Comment 7

[Ed Morley [:emorley]]

Deployed to test in bug 1056090 and works well, so calling this fixed :-)