1033013 - disable testMasterPassword

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

This test seems entirely unreliable

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: disable_testMasterPassword.patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8448956 [details] [diff] [review]
disable_testMasterPassword.patch

We may need to tear this test down and start over.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://bugzilla.mozilla.org/buglist.cgi?quicksearch=testMasterPassword

Shows 11 intermittent failures related to testMasterPassword

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d2d2713d2959

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 8448956 [details] [diff] [review]
disable_testMasterPassword.patch

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TBPL]:
[Risks and why]: 
[String/UUID change made/needed]:

Requesting approval because this blocks 3 crash fixes we want to uplift. This test has been nothing but headaches since it landed (11 bugs on it being random orange over the year) so does not provide much value.

Comment 6

[Geoff Brown [:gbrown]]

This was already skipped on Android 2.3 and Android 4.0:

[testMasterPassword] disabled for being finicky, see bug 1033013
# disabled on 2.3; bug 979603
# disabled on 4.0; bug 1006242
skip-if = android_version == "10" || android_version == "15"

With your change, testMailToContextMenu is now disabled on Android 2.3 and Android 4.0!

[testMailToContextMenu]
# [testMasterPassword] disabled for being finicky, see bug 1033013
# disabled on 2.3; bug 979603
# disabled on 4.0; bug 1006242
skip-if = android_version == "10" || android_version == "15"

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: testMasterPassword_followup.patch

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8448956 [details] [diff] [review]
disable_testMasterPassword.patch

Test only fix. Approved for Beta and Aurora.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8449451 [details] [diff] [review]
testMasterPassword_followup.patch

Spoke with Brad. This needs to land on Aurora and Beta as well.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/90bfb178a10a
https://hg.mozilla.org/releases/mozilla-beta/rev/8409d8071e20

Instead of playing around with commenting out, you could have just changed the skip-if to true. Would have saved the follow-up hassle.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ebbb3c6b4259