Closed
Bug 1033013
Opened 10 years ago
Closed 10 years ago
disable testMasterPassword
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox31 fixed, firefox32 fixed, firefox33 fixed)
RESOLVED
FIXED
Firefox 33
People
(Reporter: blassey, Assigned: blassey)
References
Details
Attachments
(2 files)
770 bytes,
patch
|
mfinkle
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
836 bytes,
patch
|
gbrown
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This test seems entirely unreliable
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → blassey.bugs
Attachment #8448956 -
Flags: review?(mark.finkle)
Comment 2•10 years ago
|
||
Comment on attachment 8448956 [details] [diff] [review] disable_testMasterPassword.patch We may need to tear this test down and start over.
Attachment #8448956 -
Flags: review?(mark.finkle) → review+
Comment 3•10 years ago
|
||
https://bugzilla.mozilla.org/buglist.cgi?quicksearch=testMasterPassword Shows 11 intermittent failures related to testMasterPassword
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d2d2713d2959
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8448956 [details] [diff] [review] disable_testMasterPassword.patch Approval Request Comment [Feature/regressing bug #]: [User impact if declined]: [Describe test coverage new/current, TBPL]: [Risks and why]: [String/UUID change made/needed]: Requesting approval because this blocks 3 crash fixes we want to uplift. This test has been nothing but headaches since it landed (11 bugs on it being random orange over the year) so does not provide much value.
Attachment #8448956 -
Flags: approval-mozilla-beta?
Attachment #8448956 -
Flags: approval-mozilla-aurora?
Comment 6•10 years ago
|
||
This was already skipped on Android 2.3 and Android 4.0: [testMasterPassword] disabled for being finicky, see bug 1033013 # disabled on 2.3; bug 979603 # disabled on 4.0; bug 1006242 skip-if = android_version == "10" || android_version == "15" With your change, testMailToContextMenu is now disabled on Android 2.3 and Android 4.0! [testMailToContextMenu] # [testMasterPassword] disabled for being finicky, see bug 1033013 # disabled on 2.3; bug 979603 # disabled on 4.0; bug 1006242 skip-if = android_version == "10" || android_version == "15"
Flags: needinfo?(blassey.bugs)
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8449451 -
Flags: review?(gbrown)
Flags: needinfo?(blassey.bugs)
Updated•10 years ago
|
Attachment #8449451 -
Flags: review?(gbrown) → review+
Comment 8•10 years ago
|
||
Comment on attachment 8448956 [details] [diff] [review] disable_testMasterPassword.patch Test only fix. Approved for Beta and Aurora.
Attachment #8448956 -
Flags: approval-mozilla-beta?
Attachment #8448956 -
Flags: approval-mozilla-beta+
Attachment #8448956 -
Flags: approval-mozilla-aurora?
Attachment #8448956 -
Flags: approval-mozilla-aurora+
Comment 9•10 years ago
|
||
Comment on attachment 8449451 [details] [diff] [review] testMasterPassword_followup.patch Spoke with Brad. This needs to land on Aurora and Beta as well.
Attachment #8449451 -
Flags: approval-mozilla-beta+
Attachment #8449451 -
Flags: approval-mozilla-aurora+
Comment 10•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/90bfb178a10a https://hg.mozilla.org/releases/mozilla-beta/rev/8409d8071e20 Instead of playing around with commenting out, you could have just changed the skip-if to true. Would have saved the follow-up hassle.
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•