1033135 - [System] Hide SIM pin dialog if the screen unlock into Camera app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

Since I changed the 'will-unlock' event to 'lockscreen-appclosing' event, the later one now bring no 'detail' like 'areaCamera', which the SIM pin dialog now rely on it, so there may be a regression.

Alive suggested me that to handle the case in 'appopened' section, and to see if the new app is relevant to SIM card. If not, hide the dialog.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

See: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/sim_lock.js#L103

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

We have discussed this offline: LockScreenWindowManager would trigger another event for those need to know what the next app is (for example, Camera in this case). So other components needn't know it can still listen to the original 'lockscreen-appclosing' event, and the components need to know it can turn to listen the new event. I prefer to call this event as 'lockscreen-request-launch' or something like that.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

UPDATE：

Current path:

User -> (drag) -> lockscreen-request-unlock (detail: camera or null) -> LWM -> close/activity close

So we can change the listener to listen the request-unlock event to solve this.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8449923 [details] [review]
Patch

r=me if LWM has test

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

TBPL is okay expect intermittent mochi tests:

https://tbpl.mozilla.org/?rev=28ff74aefaf9d70ed4619b70ed78064f26e9b497&tree=Gaia-Try

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/63976fb67d9785b200f035c36ba14f041bbaeaa6