Closed Bug 1033135 Opened 7 years ago Closed 7 years ago

[System] Hide SIM pin dialog if the screen unlock into Camera app

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gweng, Assigned: gweng)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
Since I changed the 'will-unlock' event to 'lockscreen-appclosing' event, the later one now bring no 'detail' like 'areaCamera', which the SIM pin dialog now rely on it, so there may be a regression.

Alive suggested me that to handle the case in 'appopened' section, and to see if the new app is relevant to SIM card. If not, hide the dialog.
Assignee: nobody → gweng
We have discussed this offline: LockScreenWindowManager would trigger another event for those need to know what the next app is (for example, Camera in this case). So other components needn't know it can still listen to the original 'lockscreen-appclosing' event, and the components need to know it can turn to listen the new event. I prefer to call this event as 'lockscreen-request-launch' or something like that.
UPDATE:

Current path:

User -> (drag) -> lockscreen-request-unlock (detail: camera or null) -> LWM -> close/activity close

So we can change the listener to listen the request-unlock event to solve this.
Blocks: 970824
Attached file Patch
Attachment #8449923 - Flags: review?(alive)
Comment on attachment 8449923 [details] [review]
Patch

r=me if LWM has test
Attachment #8449923 - Flags: review?(alive) → review+
master: https://github.com/mozilla-b2g/gaia/commit/63976fb67d9785b200f035c36ba14f041bbaeaa6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.