Closed Bug 1033140 Opened 7 years ago Closed 7 years ago

make speex declarations consistent with OUTSIDE_SPEEX implementation

Categories

(Core :: Web Audio, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33
blocking-b2g 2.0+
Tracking Status
firefox31 --- wontfix
firefox32 --- wontfix
firefox33 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: karlt, Assigned: karlt)

Details

Attachments

(1 file, 2 obsolete files)

resample.c is built including speex_resampler.h with OUTSIDE_SPEEX set, but
clients include speex_resampler.h with OUTSIDE_SPEEX not set, and so use
different typedefs for spx_uint32_t, etc.
Attached patch 1033140 (obsolete) — Splinter Review
Instead of defining OUTSIDE_SPEEX and RANDOM_PREFIX everywhere that
speex_resampler.h is included, it is easier to patch the header.
Attachment #8449140 - Flags: review?(paul)
Comment on attachment 8449140 [details] [diff] [review]
1033140

Don't know whether removing lines from moz.build files requires build peer review.
Attachment #8449140 - Flags: review?(gps)
Comment on attachment 8449140 [details] [diff] [review]
1033140

Need to update symbols.def.
Attachment #8449140 - Flags: review?(paul)
Symbol names in gkmedias symbols.def are updated now that RANDOM_PREFIX is
taking effect, and unused symbols are no longer exported.
Attachment #8449140 - Attachment is obsolete: true
Attachment #8449140 - Flags: review?(gps)
Attachment #8449345 - Flags: review?(paul)
Attachment #8449345 - Flags: review?(gps)
Attachment #8449345 - Attachment is obsolete: true
Attachment #8449345 - Flags: review?(paul)
Attachment #8449345 - Flags: review?(gps)
Attachment #8449348 - Flags: review?(paul)
Attachment #8449348 - Flags: review?(gps)
Comment on attachment 8449348 [details] [diff] [review]
v2.1, with C comments, not C++

Review of attachment 8449348 [details] [diff] [review]:
-----------------------------------------------------------------

You don't need build peer review for adding/removing files from moz.build files.
Attachment #8449348 - Flags: review?(gps)
Attachment #8449348 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/0f1cea1a1a95
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
[Blocking Requested - why for this release]: Blocks bug 1042508. Per bug 1042508 comment 19, uplifting this is the least-risky path to getting it uplifted. Bug 1042508 commment 29 contains a Try push of the entire patch stack on top of b2g32.
blocking-b2g: --- → 2.0?
blocking for a clean/less risky uplift of 1042508
blocking-b2g: 2.0? → 2.0+
You need to log in before you can comment on or make changes to this bug.