Closed
Bug 1033140
Opened 10 years ago
Closed 10 years ago
make speex declarations consistent with OUTSIDE_SPEEX implementation
Categories
(Core :: Web Audio, defect)
Tracking
()
People
(Reporter: karlt, Assigned: karlt)
Details
Attachments
(1 file, 2 obsolete files)
10.54 KB,
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
resample.c is built including speex_resampler.h with OUTSIDE_SPEEX set, but clients include speex_resampler.h with OUTSIDE_SPEEX not set, and so use different typedefs for spx_uint32_t, etc.
Assignee | ||
Comment 1•10 years ago
|
||
Instead of defining OUTSIDE_SPEEX and RANDOM_PREFIX everywhere that speex_resampler.h is included, it is easier to patch the header.
Attachment #8449140 -
Flags: review?(paul)
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8449140 [details] [diff] [review] 1033140 Don't know whether removing lines from moz.build files requires build peer review.
Attachment #8449140 -
Flags: review?(gps)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8449140 [details] [diff] [review] 1033140 Need to update symbols.def.
Attachment #8449140 -
Flags: review?(paul)
Assignee | ||
Comment 4•10 years ago
|
||
Symbol names in gkmedias symbols.def are updated now that RANDOM_PREFIX is taking effect, and unused symbols are no longer exported.
Attachment #8449140 -
Attachment is obsolete: true
Attachment #8449140 -
Flags: review?(gps)
Attachment #8449345 -
Flags: review?(paul)
Attachment #8449345 -
Flags: review?(gps)
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8449345 -
Attachment is obsolete: true
Attachment #8449345 -
Flags: review?(paul)
Attachment #8449345 -
Flags: review?(gps)
Attachment #8449348 -
Flags: review?(paul)
Attachment #8449348 -
Flags: review?(gps)
Comment 6•10 years ago
|
||
Comment on attachment 8449348 [details] [diff] [review] v2.1, with C comments, not C++ Review of attachment 8449348 [details] [diff] [review]: ----------------------------------------------------------------- You don't need build peer review for adding/removing files from moz.build files.
Attachment #8449348 -
Flags: review?(gps)
Updated•10 years ago
|
Attachment #8449348 -
Flags: review?(paul) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f1cea1a1a95
Flags: in-testsuite-
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0f1cea1a1a95
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Comment 9•10 years ago
|
||
[Blocking Requested - why for this release]: Blocks bug 1042508. Per bug 1042508 comment 19, uplifting this is the least-risky path to getting it uplifted. Bug 1042508 commment 29 contains a Try push of the entire patch stack on top of b2g32.
blocking-b2g: --- → 2.0?
Comment 10•10 years ago
|
||
blocking for a clean/less risky uplift of 1042508
blocking-b2g: 2.0? → 2.0+
Comment 11•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/76e3863d7b71
status-b2g-v2.0:
--- → fixed
status-b2g-v2.1:
--- → fixed
status-firefox31:
--- → wontfix
status-firefox32:
--- → wontfix
status-firefox33:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•