1033175 - revert feed preview panel to always-on-side, default-to-on, click-to-toggle-off

Status: RESOLVED FIXED

(Marketplace Graveyard :: Curation Tools, defect)

Description

[Kevin Ngo [:ngoke]]

Scott: "I got peculiar behavior with Feed Preview. I didn't see it at all unless I stretched my browser nearly the width of the screen then it would suddenly show up. "

Reasons for moving it back the sidebar to always be on the side, default to being open, but be able to toggle it off when it is not being used.

- To actually see the feed preview panel, I have to have a browser width take up 90% of my screen (>1250px). I have side tabs so the panel will never show, and it seems Scott doesn't have his browser full-screened either. Having it on the side overlayed works for all screen widths. It could even work for mobile where the drawer opens from the bottom.

- For non-super-full screen widths, the preview is on the bottom which makes it annoying to have to scroll up and down to see the preview. In some cases, it might not even be discovered.

- Putting the feed preview in the footer might work for Feed Element creation, but it does not work well for the Feed Builder. The feed builder does not have a similar footer. We don't want to maintain the feed preview panel in separate locations for different pages and screen widths.

- The feed is very vertical. It is weird to have something really tall on the bottom right corner stick out like a stilt.

- The reason why we moved it in the first place was from qualms that it was weird that we had to click to open the preview every time. Since we changed the preview to default-to-on, we no longer had reason to change it, so we should revert the most recent changes to the preview sidebar.

Comment 1

[Kevin Ngo [:ngoke]]

- Also, there are bugs in the current footer-style preview such as form errors pushing the preview section down. It's more complication.

Comment 2

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/transonic/commit/f3bceb49f0b7c5721d00c392ce467dcd026e5033