Closed Bug 1033209 Opened 6 years ago Closed 6 years ago

Lazy load gonk GPS callbacks

Categories

(Core :: DOM: Device Interfaces, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33
blocking-b2g 2.0+
Tracking Status
firefox31 --- wontfix
firefox32 --- fixed
firefox33 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: mwu, Assigned: mwu)

Details

Attachments

(1 file)

The current way of setting up gps callbacks slows down startup due to static initializers and is fragile when dealing with interfaces changes. Setting up the gps callbacks lazily avoids both problems.
Attachment #8449234 - Flags: review?(dougt)
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → All
Attachment #8449234 - Flags: review?(dougt) → review+
https://hg.mozilla.org/mozilla-central/rev/96844824ff5c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Francis,  we'll need this fix on v2.0.
blocking-b2g: --- → 2.0?
Flags: needinfo?(frlee)
(In reply to Kai-Zhen Li from comment #3)
> Francis,  we'll need this fix on v2.0.

can we get more information on why this is needed on 2.0? What is the impact if we do/(do-not) take this ?
Flags: needinfo?(kli)
Without this fix, gps service in gecko will get compile error in the solution other than qc and sprd (when there is interfaces changes). Now we already hit this error in a on-going project.
Flags: needinfo?(kli)
blocking-b2g: 2.0? → 2.0+
Correct tracking flags.
Flags: needinfo?(frlee)
Please don't add checkin-needed to uplifts. We have different bug queries for them.
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #7)
> Please don't add checkin-needed to uplifts. We have different bug queries
> for them.

Noted, Thanks!
You need to log in before you can comment on or make changes to this bug.