[Vertical homescreen] Intermittent MarionetteJS failure on Travis: 1) Vertical - Bookmark Uninstall removal of bookmark: NoSuchElement: (7) Unable to locate element: gaia-confirm[data-type="remove"]

RESOLVED FIXED in 2.1 S7 (24Oct)


Firefox OS
4 years ago
17 days ago


(Reporter: julienw, Assigned: kgrandon)



2.1 S7 (24Oct)

Firefox Tracking Flags

(Not tracked)


(Whiteboard: [systemsfe])


(1 attachment, 1 obsolete attachment)

46 bytes, text/x-github-pull-request
: review+
Details | Review | Splinter Review


4 years ago
1) Vertical - Bookmark Uninstall removal of bookmark:

NoSuchElement: (7) Unable to locate element: gaia-confirm[data-type="remove"]

Remote Stack:


at Error.MarionetteError (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/error.js:67:13)

at Object.Client._handleCallback (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:476:19)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:510:21

at TcpSync.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:100:10)

at Object.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:457:36)

at Object.Client._sendCommand (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:503:19)

at Object._findElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1303:19)

at Object.findElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1352:32)

at Object.MarionetteHelper.waitForElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-helper/index.js:139:19)

at Object.Home2.getConfirmDialog (/home/travis/build/mozilla-b2g/gaia/apps/verticalhome/test/marionette/lib/home2.js:78:31)

at Object.Home2.confirmDialog (/home/travis/build/mozilla-b2g/gaia/apps/verticalhome/test/marionette/lib/home2.js:87:23)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/verticalhome/test/marionette/bookmark_uninstall_test.js:59:10)
Kevin: Could you prioritize this accordingly in your team?
Flags: needinfo?(kgrandon)

Comment 4

4 years ago
Created attachment 8449504 [details] [review]
Github pull request
Flags: needinfo?(kgrandon)

Comment 5

4 years ago
Currently testing this fix on travis: https://travis-ci.org/KevinGrandon/gaia/builds/28977727


4 years ago
Blocks: 1035939

Comment 6

4 years ago
Disabled in Travis only in:
master: 721823f356bc0b1691d5b2fd87169fb60efae80b

I don't see it failing on TBPL these days.
Keywords: leave-open

Comment 8

4 years ago
Seems to be failing a lot on TBPL these days, so disabled there as well: https://github.com/mozilla-b2g/gaia/commit/2d6b361c13a45fb2b4f47da35ac7f12e6cc20106

Comment 9

4 years ago
Created attachment 8505785 [details] [review]
Github pull request

Reviving this PR.
Attachment #8449504 - Attachment is obsolete: true

Comment 10

4 years ago
Comment on attachment 8505785 [details] [review]
Github pull request

Just needed to add one line to resolve this, so going to land with r=me. This just adds a home.moveIconToIndex(icon, 0); which is what we do in almost all other tests. I'm guessing this is some marionette issue.
Attachment #8505785 - Flags: review+

Comment 11

4 years ago
Master: https://github.com/mozilla-b2g/gaia/commit/20dcee03f370d2a681a9519bcf1b538749a18293
Assignee: nobody → kgrandon
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S7 (24Oct)

Comment 12

4 years ago
At one point, I'd like to experiment sleeping for some time after scrolling instead of moving the icon to prevent scrolling at all.

One guess I have is that because scrolling is now asynchronous, calling scrollIntoView does not have an immediate effect.
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.