Closed
Bug 1033232
Opened 10 years ago
Closed 10 years ago
[Calendar] Permared MarionetteJS failure on Travis on the v2.0 branch: event hour: expected '' to equal 'All Day'
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(b2g-v1.4 unaffected, b2g-v2.0 fixed, b2g-v2.1 unaffected)
RESOLVED
FIXED
2.0 S5 (4july)
| Tracking | Status | |
|---|---|---|
| b2g-v1.4 | --- | unaffected |
| b2g-v2.0 | --- | fixed |
| b2g-v2.1 | --- | unaffected |
People
(Reporter: julienw, Assigned: mmedeiros)
Details
1) creating events creating one all day event should display the created event in months day: event hour: expected '' to equal 'All Day' 2) creating events creating multiple all day event should display the created event in months day: event hour: expected '' to equal 'All Day' https://travis-ci.org/mozilla-b2g/gaia/jobs/28916087
|
Reporter | |
Comment 1•10 years ago
|
||
Gareth, since permareds are unacceptable, could you or someone from your team have a look at this?
Flags: needinfo?(gaye)
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → mmedeiros
Flags: needinfo?(gaye)
Target Milestone: --- → 2.0 S5 (4july)
|
|
Assignee | |
Comment 2•10 years ago
|
||
this is a real bug! not only marionette error. it looks like the [data-l10n-id] is handled differently by 2.0 and 2.1, on 2.1 it is translating the element when we call `insertAdjacentHTML`, on 2.0 it doesn't. unsure on how to proceed in this case, but I think we should backout https://github.com/mozilla-b2g/gaia/commit/f7f067b0652ed36c740d6f21bc587db54602642d (Bug 1030552) and submit a new patch for v2.0
|
|
Assignee | |
Comment 3•10 years ago
|
||
backed out the patch for Bug 1030552 on branch v2.0: https://github.com/mozilla-b2g/gaia/commit/d2e6f32788bb28781fd1484d190f78b98464d31c
|
|
Reporter | |
Comment 4•10 years ago
|
||
Yep, in v2.0 you have to call "translate" explicitely on the node.
You need to log in
before you can comment on or make changes to this bug.
Description
•