Make use of tags to properly distinguish and handle the different dialer notifications

RESOLVED WONTFIX

Status

Firefox OS
Gaia::Dialer
RESOLVED WONTFIX
4 years ago
2 years ago

People

(Reporter: gsvelto, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

The dialer was recently converted to use new style notifications but fails to leverage the new features to properly distinguish between different notifications or close existing ones:

- Facebook-related notifications are flagged by "hiding" parameters in the icon URL: https://github.com/mozilla-b2g/gaia/blob/b0ddb2122771e25cdd880359406a53b10cdc0507/apps/communications/facebook/js/fb_sync_init.js#L76

- We clean all notifications upon opening the call log irrespective of where they were coming from, this makes it hard to add new ones that need to persist: https://github.com/mozilla-b2g/gaia/blob/b0ddb2122771e25cdd880359406a53b10cdc0507/apps/communications/dialer/js/call_log.js#L1063

To clean this up and make notifications a little more manageable we should use tags to properly distinguish notifications instead of abusing the icon URL and close only the missed-calls notifications when starting up.
I'm putting this under dialer-most-wanted because we're basically limiting the dialer behavior to cope with API limitations that haven't been in place anymore for over a year.
Blocks: 1036516
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.