Closed Bug 1033259 Opened 7 years ago Closed 7 years ago

Remove the settings permission from the manifest

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

Details

Attachments

(1 file)

Now that languagechange has landed in bug 889335, I don't think the settings permission is needed anymore for this app.
Attached patch bug1033259.patchSplinter Review
Assignee: nobody → 21
Attachment #8449288 - Flags: review?(kgrandon)
Comment on attachment 8449288 [details] [diff] [review]
bug1033259.patch

Review of attachment 8449288 [details] [diff] [review]:
-----------------------------------------------------------------

Did some quick greps, but could not find mention of anything using settings, and IIRC we just used a local IDB for settings. Seems fine to me, thanks!
Attachment #8449288 - Flags: review?(kgrandon) → review+
You need to log in before you can comment on or make changes to this bug.