Modifier for multiple job selection using mouse is different from TBPL

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: emorley, Assigned: jfrench)

Tracking

Details

(URL)

The Treeherder modifier for selecting multiple jobs (adding multiple jobs to the pin board) is "shift" rather than TBPL's "ctrl". 

Also, most OSes/other apps use ctrl to mean "add single item to current list" and shift to mean "add range to list" - so I think ctrl makes more sense here, even if we weren't worried about preserving TBPL functionality.
Summary: Keyboard modifier for multiple job selection is different from TBPL → Modifier for multiple job selection using mouse is different from TBPL
(Assignee)

Comment 1

5 years ago
I'll have a look at this, and see what I can do.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Everything seems to be behaving as expected. I've opened a PR for review
https://github.com/mozilla/treeherder-ui/pull/101
(Assignee)

Comment 3

5 years ago
The PR has been landed on master and I've tested it on dev and everything appears to be correct. I will retest after it is pushed to production and will mark it Fixed.
(Assignee)

Comment 4

5 years ago
It turns out we need to provide Mac support also - with Cmd+click since that was supported in TBPL on OSX. Ctrl+click on Mac just fires a context menu and the log which is not what we want. Since I'm windows only here, Cameron has addressed that with the commit below.

https://github.com/mozilla/treeherder-ui/commit/7e557a3ebaa2c0ae41498b0485b9c87645f33c4b

It's been pushed to dev/stage, and will be pushed to prod next week.
(Assignee)

Comment 5

4 years ago
Camd has pushed to prod, and it appears to be working fine. Marking resolved fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.