1033283 - Expose STATE_PRESSED on menu buttons

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

Currently, we don't expose the pressed state on xul:button or xul:toolbarbutton of type "menu", as used in the web console. This bug was uncovered by the patch for bug 977273. We transform the role to a toggle button with the HASPOPUP state, but don't expose the pressed state.

Comment 1

[Athena]

I'd like to take a crack at this.

Comment 2

[Marco Zehe (:MarcoZ)]

Athena, in testing your patch, I actually fixed this one. It is a one-line test in code, but needs some tests added. I just got back from lunch and am testing my tests and will attach a patch shortly.

Sorry for "stealing" this one! :)

Comment 3

[Marco Zehe (:MarcoZ)]

Attachment: Expose pressed state on menu buttons, too

One-line fix, and I added tests for the role and states.

Comment 4

[Athena]

Hah, no problem! I did take a look (before my dinner ;)), and I was way off base. I'll just look around for another one.

Comment 5

[alexander :surkov (:asurkov)]

Comment on attachment 8449368 [details] [diff] [review]
Expose pressed state on menu buttons, too

Review of attachment 8449368 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/generic/Accessible.cpp
@@ +1581,5 @@
>      }
>    }
>  
>    // special case: A native button element whose role got transformed by ARIA to a toggle button
> +  // Also applies to togglable button  menus, like in the Dev Tools Web Console

nit: two spaces between 'button' and 'menus', dot in the end

::: accessible/tests/mochitest/states/test_aria.xul
@@ +3,5 @@
> +<?xml-stylesheet href="chrome://mochikit/content/tests/SimpleTest/test.css"
> +                 type="text/css"?>
> +
> +<window xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
> +        title="Accessible XUL toggle button state tests">

nit: it'd bet good to keep it more generic

Comment 6

[Marco Zehe (:MarcoZ)]

Landed with nits addressed: https://hg.mozilla.org/integration/mozilla-inbound/rev/62eec1dede89

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/62eec1dede89