Closed
Bug 1033330
Opened 9 years ago
Closed 9 years ago
UI updating after adding/removing a jobname filter takes longer than TBPL
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: camd)
References
Details
(Keywords: perf)
Attachments
(1 file)
1) Go to https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound 2) Wait for the page to fully load. 3) Click in the filter field top-right of the UI, type in "marionette". 4) Press enter & observe time taken for the UI to update. 5) Delete the text in the filter field and repeat step 4. 6) Repeat steps 2-5 with https://tbpl.mozilla.org/?tree=Mozilla-Inbound (use the "job name" filter under the "filters" menu). Expected: Same time or quicker than TBPL for the UI to update Actual: TBPL updates virtually instantly. Treeherder takes ~1.5-2 seconds to add the filter, and ~2.5 seconds to remove the filter.
Reporter | ||
Updated•9 years ago
|
Summary: UI updates after adding and removing a job name filter is slower than TBPL → UI updating after adding/removing a jobname filter takes longer than TBPL
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
We should actually move the global "field filters" section to the nav bar where we have the type-in filter. But that field should allow you to specify which field you're filtering on. And then it will add a little "chicklet" to the bar to indicate filtering is happening on that field.
Assignee | ||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Cameron Dawson [:camd] from comment #1) > We should actually move the global "field filters" section to the nav bar > where we have the type-in filter. But that field should allow you to > specify which field you're filtering on. And then it will add a little > "chicklet" to the bar to indicate filtering is happening on that field. this is a different bug: bug 1046927
Assignee | ||
Comment 4•9 years ago
|
||
The fix for this takes the filter time to ~1 second for adding or removing. It's still a bit slower than TBPL. But hopefully this moves it into the acceptable range. https://github.com/mozilla/treeherder-ui/commit/dbc7d5c22481df76057289d53649dc61aab6afd0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•9 years ago
|
||
Looking good - thank you :-)
You need to log in
before you can comment on or make changes to this bug.
Description
•