UI updating after adding/removing a jobname filter takes longer than TBPL

RESOLVED FIXED

Status

Tree Management
Treeherder
P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: emorley, Assigned: camd)

Tracking

({perf})

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
1) Go to https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound
2) Wait for the page to fully load.
3) Click in the filter field top-right of the UI, type in "marionette".
4) Press enter & observe time taken for the UI to update.
5) Delete the text in the filter field and repeat step 4.
6) Repeat steps 2-5 with https://tbpl.mozilla.org/?tree=Mozilla-Inbound (use the "job name" filter under the "filters" menu).

Expected:
Same time or quicker than TBPL for the UI to update

Actual:
TBPL updates virtually instantly. Treeherder takes ~1.5-2 seconds to add the filter, and ~2.5 seconds to remove the filter.
(Reporter)

Updated

4 years ago
Summary: UI updates after adding and removing a job name filter is slower than TBPL → UI updating after adding/removing a jobname filter takes longer than TBPL
(Assignee)

Updated

4 years ago
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
We should actually move the global "field filters" section to the nav bar where we have the type-in filter.  But that field should allow you to specify which field you're filtering on.  And then it will add a little "chicklet" to the bar to indicate filtering is happening on that field.
(Assignee)

Comment 2

4 years ago
Created attachment 8465644 [details] [review]
pull request
(Assignee)

Comment 3

4 years ago
(In reply to Cameron Dawson [:camd] from comment #1)
> We should actually move the global "field filters" section to the nav bar
> where we have the type-in filter.  But that field should allow you to
> specify which field you're filtering on.  And then it will add a little
> "chicklet" to the bar to indicate filtering is happening on that field.

this is a different bug: bug 1046927
(Assignee)

Comment 4

4 years ago
The fix for this takes the filter time to ~1 second for adding or removing.  It's still a bit slower than TBPL.  But hopefully this moves it into the acceptable range.  

https://github.com/mozilla/treeherder-ui/commit/dbc7d5c22481df76057289d53649dc61aab6afd0
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

4 years ago
Looking good - thank you :-)
(Reporter)

Updated

4 years ago
Keywords: perf
You need to log in before you can comment on or make changes to this bug.