1033343 - Crash [@ XPCVariant::VariantDataToJS] with CustomEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Jesse Ruderman]

Attachment: testcase

I'm guessing this is a regression from bug 1031051 (patch part 17 reimplemented CustomEvent).

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This is so expected whenever one deals with JS manually :/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

The old code had
  nsresult rv = NS_ERROR_UNEXPECTED;
  if (!mDetail) {
    aRetval.setNull();
  } else if (!XPCVariant::VariantDataToJS(mDetail, &rv, aRetval)) {
    aRv.Throw(NS_ERROR_FAILURE);
  }

the new one 
VariantToJsval(aCx, mDetail, aRetval);

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e1af3a64216

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7e1af3a64216