If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Header text in bookmarks activity is misaligned

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cwiiis, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8449398 [details]
Screenshot

The header text does not appear centered in the bookmarks activity.
That's because the header has 2 h1 elements, one only being visible at each time. This messes up with the text size calculations.

So we need to detect when the h1 visibility changes and emit a `lazyload` event.
Created attachment 8451541 [details] [review]
Github PR

This PR fixes the header (add and edit modes). Cristian, can you review it?
Attachment #8451541 - Flags: review?(crdlc)
Comment on attachment 8451541 [details] [review]
Github PR

LGTM, r+
Attachment #8451541 - Flags: review?(crdlc) → review+
Thanks Cristian, it has landed:
https://github.com/mozilla-b2g/gaia/commit/6a1a5250852b8a44f7d16a7dd961d76f25534ee0
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.