Closed Bug 1033372 Opened 10 years ago Closed 10 years ago

Clicking outside of the sheriffing/repos/filters menu panels should dismiss them

Categories

(Tree Management :: Treeherder, defect, P3)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: RyanVM, Assigned: camd)

References

Details

In the current TBPL UI, clicking in the whitespace outside of a toolbar dismisses it. I find it to be difficult from a muscle memory standpoint to have to hunt around the screen to find the right button to click when I want to dismiss whatever toolbar is popped up (or down) vs. being able to click anywhere outside of it to do so instead.
Being able to click away from a job and free up the screen estate occupied by the job info panel is very useful in TBPL, would be great to be able to do this in treeherder too.
Blocks: treeherder-sheriff-transition
Priority: -- → P3
Summary: Clicking outside of toolbars should dismiss them → Clicking away from a job in the main UI should close the job detail panel
Sorry I misunderstood, I'll file another bug for the job details panel.

Regarding the sheriffing/filters/repos menus I'm not sure what's best. The current workflow is definitely confusing, but I wonder whether for certain menus (eg the filters menu) people may wish to have it open all the time?

Either way, what may help is:
1) Make it so only one menu can be open at once
2) Make some of the lesser-used menus close when clicking outside
3) Add a "x" in the corner of the menu panel so you can just click that rather than having to work out which menu toggle needs pressing
4) Make the toggle state of each menu button more obvious - eg: change the background colour more to distinguish between enabled and disabled more easily - that way it's clearer which needs clicking to close the current panel.
Summary: Clicking away from a job in the main UI should close the job detail panel → Clicking outside of the sheriffing/repos/filters menu panels should dismiss them
See Also: → 1042711
See Also: → 1042646
Blocks: 1053985
So in the course of other work I discovered the esc key closes all job/repo/filter panels. I wasn't aware of this functionality. I'm not sure if you folks were either, in the context of this bug. Is this sufficient functionality to address the workflow need? I opened a PR to update the help, since it wasn't present there.
https://github.com/mozilla/treeherder-ui/pull/130

I think I have already addressed bug 1042711 for the more frequent workflow of 'clicking in empty space' to close the job panel, and I have a pending PR open for that. With the upcoming repo state - you'd have the flexibility of closing the job panel with an empty click, _and keeping your repo or master filter panels open if you wished. And you could easily close the repo/filter via an esc if you wished. Or close all three via esc if jobs was open also.

Thoughts?
Flags: needinfo?(emorley)
I didn't know about esc doing that, thank you :-)

That said, I think it would still be good to implement this (albeit it means the relative important of this bug is slightly lower now).
Flags: needinfo?(emorley)
Do you think this could be considered a non-blocker bug at this time, in that context?
(In reply to Jonathan French (:jfrench) from comment #5)
> Do you think this could be considered a non-blocker bug at this time, in
> that context?

Given that bug 1053985 is the overall blocker and that esc can be used, let's demote this for now.
No longer blocks: treeherder-sheriff-transition
fixed in https://github.com/mozilla/treeherder-ui/commit/1ac87534a44c7ff5e8ae000752cb878800e9b272
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee: nobody → cdawson
You need to log in before you can comment on or make changes to this bug.