1033426 - Appmaker need its own category in profile

Status: RESOLVED DUPLICATE of bug 1076957

(Webmaker Graveyard :: Profile, defect)

Description

[Bobby Richter [:secretrobotron]]

https://cloud.githubusercontent.com/assets/403231/3455685/eb057072-01e5-11e4-969c-b31b321c1808.png

Can we add "Apps" or "Appmaker" to the list of categories on makes.org along side Popcorn, Thimble, and X-Ray Goggles? (e.g. https://webmaker.org/user/secretrobotron/makes)

Comment 1

[Jon Buckley [:jbuck]]

This is a tab within webmaker-profile-2, not something on makes.org. What content-type is Appmaker using for makes within the MakeAPI?

Comment 2

[Bobby Richter [:secretrobotron]]

Our code says "contentType: 'Appmaker'" (https://github.com/mozilla-appmaker/appmaker/blob/develop/lib/makeapi-publisher.js#L31). Scott can verify.

Comment 3

[Scott [:thecount] Downe]

Yup, verified it is "Appmaker" for content type.

Comment 4

[Gavin Suntop [:gvn]]

I'm going to need an updated sprite asset with Appmaker added.

See:

https://webmaker.org/user/_img/tools_sprite.png

Comment 5

[Tanay Pant [:Tanay]]

How to implement this? Other than adding changes to / app / _partials / makes.html

Comment 6

[Tanay Pant [:Tanay]]

Previous comment obsolete:

Changes at: 
/app/_js/app.js
/app/index.html
app/_partials/

Can't figure out what to add on the _partials files, help please?

Comment 7

[Tanay Pant [:Tanay]]

Or just to / app / _partials / makes.html if appmaker is to be a sub-category?

Comment 8

[Aki Rose Braun [:akirose]]

I think in order to accomplish I’d do the following:

1. Update app/_img/tools_sprite.png to change appmaker’s logo
2. Update app/index.html line 105 group to include Apps (and maybe change that <div> to a <nav>)
3. Create an appmaker controller in app/_js/controllers.js
4. From there I’d probably guess and check, but if you want to make something with the Appmaker, I’d be happy to poke around in the resulting MakeAPI json data

This is kind of a guess, but seems like a good place to start.

Comment 9

[Cassie McDaniel [:cassiemc]]

Reassigning to Luke for the next train. Luke, see comment 4 for the requirement here. If needed you can pass off to Wex when you're done to assign implementation.

Comment 10

[Luke Pacholski]

Okay, on it - do you know where the original version of that sprite file lives? Do mofo design files live somewhere share-able?

Comment 11

[Luke Pacholski]

Attachment: Updated tools sprite with Appmaker brick

Comment 12

[Luke Pacholski]

Gavin, let me know if this fits or needs updates, cheers.