Closed Bug 1033445 Opened 6 years ago Closed 6 years ago

Certain webservice methods such as Bug.get and Bug.attachments should not use shadow db if user is logged in

Categories

(Bugzilla :: WebService, defect)

4.5.4
defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 5.0

People

(Reporter: dkl, Assigned: dkl)

References

Details

Attachments

(1 file)

No description provided.
Propose not using shadow DB when user is authenticated and uses Bug.get, Bug.comments, and Bug.attachments similar to what we do not with show_bug.cgi and attachment.cgi. When using the midair checking in an extension for BMO, a user created an attachment and right after update the bug's status with a separate call. The second call caused a midair collision even though the client reloaded the bug data using a Bug.get call and passed in the timestamp. The timestamp was from one of our slave dbs and did not yet have the updated value from the attachment creation.

We should be ok with updating the following methods: Bug.get and Bug.attachments as they both have related methods for updating, Bug.update and Bug.update_attachment.

dkl
Assignee: webservice → dkl
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Summary: Certain webservice methods such as Bug.get and Bug.comments, and Bug.attachments should not use shadow db if user is logged in → Certain webservice methods such as Bug.get and Bug.attachments should not use shadow db if user is logged in
Target Milestone: --- → Bugzilla 5.0
Attached patch 1033445_1.patchSplinter Review
Attachment #8449526 - Flags: review?(sgreen)
Blocks: 1033394
Attachment #8449526 - Flags: review?(sgreen) → review+
I've done minimal testing since I don't have a slave server in my set up.
Flags: approval?
Flags: approval? → approval+
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   99e02ea..eb527a5  master -> master
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.