Closed
Bug 1033470
Opened 10 years ago
Closed 7 years ago
Add Tor panel in Firefox OS settings.
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: janx, Assigned: janx)
Details
(Keywords: privacy)
Attachments
(4 files, 1 obsolete file)
If Tor gets integrated into Gecko, Firefox OS will need a settings menu to enable and control Tor.
Assignee | ||
Updated•10 years ago
|
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → All
Assignee | ||
Comment 1•10 years ago
|
||
WIP. Control panel is incomplete and assets need more love.
Assignee | ||
Updated•10 years ago
|
Summary: Add Tor setting in Firefox OS → Add Tor panel in Firefox OS settings.
Assignee | ||
Comment 2•10 years ago
|
||
New pull request to 2.0.
Attachment #8449551 -
Attachment is obsolete: true
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
Carol, could you please help with the assets?
As you can see in screenshot.png, I did a bad job with the status icons (system tray) and the settings icon (settings app).
If you have time, could you please make nicer onion icons? In the gaia pull request, you can see which icons I added (4 icons for the settings app, and 8 icons for the system app). Please don't integrate them in the sprites, because they will need to move around in different Gaia branches before integration.
I based my icons on onion.png, which is a Public Domain image from thenounproject.com, but simply rescaling it doesn't look good in the settings, and even worse in the system app.
Many thanks!
Flags: needinfo?(chuang)
Assignee | ||
Comment 5•10 years ago
|
||
Oh, and my `tor-connecting*.png` icons are yellow. I think we don't want to have yellow icons anymore, but animated PNG icons. Would it be easy to make an animated onion icon (maybe with a rotating onion)?
For this pull request, yellow icons are still OK, so please only make an animated icon if it's very easy / if it doesn't take you too much time. Thanks!
Comment 6•10 years ago
|
||
Hi Jan,
The onion icon is cute!
But it's not that clear on the status :P
Helen is in charge of Settings right now. She will take care of this. Thanks!!
Flags: needinfo?(chuang) → needinfo?(hhuang)
Updated•10 years ago
|
Flags: needinfo?(hhuang)
Assignee | ||
Comment 7•10 years ago
|
||
Thanks Carol!
Helen, I see that you removed the `needinfo` flag a few days ago. Does that mean that you are working on the image (see comment 4), or that you can't help me? Thanks :)
Flags: needinfo?(hhuang)
Comment 8•10 years ago
|
||
Hi Jan,
Sorry for that I removed ni accidentally... I can help with the onion icon to make it more clear in Settings and Status bar.
Just a question about that you mentioned making an animated icon on Comment 5, do you mean you also need an animated icon in Status bar while connecting? I would also like to know if any connection status is needed, something like 'no connect'. Thank you!
Flags: needinfo?(hhuang)
Assignee | ||
Comment 9•10 years ago
|
||
Hi Helen, thanks for your help! To answer your questions:
- No need for a 'no connection' status bar icon, we'll just need 'connecting' and 'connected'.
- It would be nice if the 'connecting' status icon is an animated white icon, but it's not necessary. If an animated white icon is hard to make, a static yellow icon is also fine.
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(hhuang)
Comment 10•10 years ago
|
||
Hi Jan, does this setting appear by default or does it detect the availability of Tor in Gecko?
Flags: needinfo?(janx)
Assignee | ||
Comment 11•10 years ago
|
||
Hi Bruce, the Tor settings panel will only be visible if Tor is available, e.g. if it was built into the Firefox OS image.
The status icon will then reflect the status setting `tor.status`, which will be modified by the Gecko part to `disconnected` (no status icon), `connecting` (yellow icon or animated icon) and `connected` (white icon).
Flags: needinfo?(janx)
Assignee | ||
Comment 12•10 years ago
|
||
Hi Helen, any news on the icons? :)
Comment 13•10 years ago
|
||
Hi Jan, sorry I'm a bit busy those days, so I'm still working on this icon and will update it by next week...
Flags: needinfo?(hhuang)
Assignee | ||
Comment 14•10 years ago
|
||
Hi Helen, no problem about the delay, please take your time.
Also, I'm setting needinfo again just for my sake, so that I don't forget about this bug and notice when you update it. I hope you don't mind.
Flags: needinfo?(hhuang)
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(hhuang)
Comment 16•10 years ago
|
||
Hi Jan, sorry for taking a long time to update. I've redesign the tor icon in Settings, so that the icon style is more aligned with the others. For the one in Status bar, I didn't make an animated icon, only a static one for now.
The zip file includes 4 sizes icons, also svgs in case it's needed, please let me know if there is any question.
Thank you!
Flags: needinfo?(hhuang)
Assignee | ||
Comment 17•10 years ago
|
||
Thanks a lot Helen! The icons look great.
Comment 18•10 years ago
|
||
Woohoo! Thanks Helen.
Comment 19•10 years ago
|
||
Jan, will you update your UI patch to use the new icons and rebase to v2.1?
Flags: needinfo?(janx)
Comment 21•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•