Use a .mozbuild file rather than a .mk in m/a/tests/background/junit3

RESOLVED FIXED in Firefox 33

Status

Android Background Services
Build & Test
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

unspecified
Firefox 33
All
Android
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
We're currently writing a .mk file in the Background JUnit 3 tests.  We should write a .mozbuild and get some of that logic out of Makefiles.
(Assignee)

Comment 1

4 years ago
Created attachment 8452050 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/470

m-c patch coming up.
Attachment #8452050 - Flags: review?(rnewman)
(Assignee)

Comment 2

4 years ago
Created attachment 8452053 [details] [diff] [review]
Use a .mozbuild file rather than a .mk in m/a/tests/background/junit3. r=rnewman

And here's the m-c patch.
Attachment #8452053 - Flags: review?(rnewman)
Comment on attachment 8452050 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/470

Rubberstamp.

http://imgur.com/bZSAo
Attachment #8452050 - Flags: review?(rnewman) → review+
Comment on attachment 8452053 [details] [diff] [review]
Use a .mozbuild file rather than a .mk in m/a/tests/background/junit3. r=rnewman

Review of attachment 8452053 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/tests/background/junit3/background_junit3_sources.mozbuild
@@ +1,1 @@
> +# -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*-

Extra points if you trick hg into thinking this is a rename+change.
Attachment #8452053 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/e3f62c645356
https://hg.mozilla.org/mozilla-central/rev/e3492dba1b2d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
You need to log in before you can comment on or make changes to this bug.