1033481 - Use a .mozbuild file rather than a .mk in m/a/tests/background/junit3

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Build & Test, defect)

Description

[Nick Alexander :nalexander [he/him]]

We're currently writing a .mk file in the Background JUnit 3 tests.  We should write a .mozbuild and get some of that logic out of Makefiles.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/470

m-c patch coming up.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Use a .mozbuild file rather than a .mk in m/a/tests/background/junit3. r=rnewman

And here's the m-c patch.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8452050 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/470

Rubberstamp.

http://imgur.com/bZSAo

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8452053 [details] [diff] [review]
Use a .mozbuild file rather than a .mk in m/a/tests/background/junit3. r=rnewman

Review of attachment 8452053 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/tests/background/junit3/background_junit3_sources.mozbuild
@@ +1,1 @@
> +# -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*-

Extra points if you trick hg into thinking this is a rename+change.

Comment 5

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/e3f62c645356

and clobber:

https://hg.mozilla.org/integration/fx-team/rev/e3492dba1b2d

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e3f62c645356
https://hg.mozilla.org/mozilla-central/rev/e3492dba1b2d