1033535 - Eclipse: Resource building issues with Android support library and Play Services

Status: VERIFIED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Richard Newman [:rnewman]]

After ChromeCast support landed, we need Play Services and MediaRouter in order for Eclipse to build Fennec.

Here's what I did:

* Install all of the Play Services crap from inside the SDK manager.
* Import android-support-v7-{mediarouter,gridlayout,appcompat} as Eclipse projects, and get those building with dependencies on each other.
* Import google-play-services_lib as an Eclipse project.

* Remove the v4 support library from the Fennec build path. (It exports symbols that the v7 library exposes, so this is necessary to prevent dex from failing.)
* Add android-support-v7-mediarouter and google-play-services_lib to the Fennec Android library pane. (The Android library pane seems to be preferred over the build path.)


Here's what happens on launch:

 Exception starting favicon cache. Corrupt resources?
 android.content.res.Resources$NotFoundException: Resource ID #0x7f0b0009
 	at android.content.res.Resources.getValue(Resources.java:1134)
 	at android.content.res.Resources.getDimensionPixelSize(Resources.java:629)
 	at org.mozilla.gecko.favicons.Favicons.attachToContext(Favicons.java:384)
 	at org.mozilla.gecko.GeckoApp.onCreate(GeckoApp.java:1186)
 	at org.mozilla.gecko.BrowserApp.onCreate(BrowserApp.java:474)
 	at android.app.Activity.performCreate(Activity.java:5312)


I've also seen issues with missing mozglue, but that seemed to resolve itself.

And finally, this also manifests itself just like Bug 1006631.

Comment 1

[Nick Alexander :nalexander [he/him]]

There are two things here:

1. Eclipse configuration is busted when MOZ_NATIVE_DEVICES is disabled.

2. Eclipse configuration is busted when MOZ_NATIVE_DEVICES is enabled.

The first is easy, patch incoming.  The second is not easy, but is a separate ticket.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Exclude some source files when MOZ_NATIVE_DEVICES is disabled. r=rnewman

We'll get to the other Eclipse stuff at some point, hopefully before
we flip that switch.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8449765 [details] [diff] [review]
Exclude some source files when MOZ_NATIVE_DEVICES is disabled. r=rnewman

Review of attachment 8449765 [details] [diff] [review]:
-----------------------------------------------------------------

Hacky but I'll take it!

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/cd8a011bad4f

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd8a011bad4f

Comment 6

[Nick Alexander :nalexander [he/him]]

See also Bug 1053494, which adds Eclipse support for when the MOZ_NATIVE_DEVICES flag is enabled.