1033643 - browser_alarm test times out after successfully adding alarm

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

The browser_alarm test times out after successfully adding the alarm:

 0:39.25 TEST-START | chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_alarm.js
System JS : ERROR file:///Users/myk/Mozilla/gecko-dev/obj-x86_64-apple-darwin13.2.0/dist/NightlyDebug.app/Contents/MacOS/components/nsHandlerService.js:891 - NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]
 0:40.16 [82879] WARNING: getting z level of unregistered window: file /Users/myk/Mozilla/gecko-dev/xpfe/appshell/src/nsWindowMediator.cpp, line 591
 0:40.16 [82879] WARNING: getting z level of unregistered window: file /Users/myk/Mozilla/gecko-dev/xpfe/appshell/src/nsWindowMediator.cpp, line 591
 0:40.30 [82879] WARNING: NS_ENSURE_TRUE(mTextInputHandler) failed: file /Users/myk/Mozilla/gecko-dev/widget/cocoa/nsChildView.mm, line 5525
 0:40.71 TEST-PASS | chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_alarm.js | Alarm permission: allow.
 0:40.74 TEST-PASS | chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_alarm.js | Alarm added.
 1:24.29 Failed to retrieve MOZ_UPLOAD_DIR env var
 1:24.29 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_alarm.js | Test timed out


I see this on all three primary platforms.  It appears to be different from bug 1033059, which obscures it.

Comment 1

[Marco Castelluccio [:marco]]

Are you seeing this locally?

This may have something to do with the messages SystemMessageInternal.js is observing: http://mxr.mozilla.org/mozilla-central/source/dom/messages/SystemMessageInternal.js#512

We're re-sending "webapps-registry-start" for each test app, but we aren't sending "webapps-registry-ready".

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Yes, I see it locally!

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Erm, but it gets obscured by all the failures from bug 1033059, so it's easier to see if you apply the fix for that bug first.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: notify webapps-registry-ready while becoming webapp

Nice catch!  Notifying webapps-registry-ready does indeed fix the problem.

Comment 5

[Marco Castelluccio [:marco]]

Comment on attachment 8450624 [details] [diff] [review]
notify webapps-registry-ready while becoming webapp

Review of attachment 8450624 [details] [diff] [review]:
-----------------------------------------------------------------

::: webapprt/content/mochitest-shared.js
@@ +76,5 @@
>      Services.prefs.setCharPref("webapprt.buildID", WebappRT.config.app.manifestURL);
>  
>      // During tests, the webapps registry is already loaded.
>      // The Startup module needs to be notified when the webapps registry
>      // gets loaded, so we do that now.

Since you're here, could you update this comment? We used to notify the observers
for this reason, now we're notifying just for System Messages.

(The Startup module doesn't need to be notified when the webapps registry gets
loaded anymore, since we're now using the registryStarted promise)

Comment 6

[Marco Castelluccio [:marco]]

(In reply to Myk Melez [:myk] [@mykmelez] from comment #2)
> Yes, I see it locally!

(In reply to Myk Melez [:myk] [@mykmelez] from comment #3)
> Erm, but it gets obscured by all the failures from bug 1033059, so it's
> easier to see if you apply the fix for that bug first.

I can't reproduce neither one :P

Comment 7

[Myk Melez [:myk] [@mykmelez]]

(In reply to Marco Castelluccio [:marco] from comment #5)
> Since you're here, could you update this comment? We used to notify the
> observers
> for this reason, now we're notifying just for System Messages.

Yes, good point!  I updated the comment in the patch I pushed to fx-team:

https://hg.mozilla.org/integration/fx-team/rev/051c18b47f27

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/051c18b47f27