1033656 - mach mercurial-setup integration for reviewboard

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Gregory Szorc [:gps]]

I keep forgetting that I promised to update `mach mercurial-setup` to configure reviewboard. Filing a bug so I don't forget any longer.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Add reviewboard to mach mercurial-setup; version checking

We want to make it turnkey for people to use reviewboard. So, we add
reviewboard and related functionality to |mach mercurial-setup|.

Since the reviewboard extension only works in Mercurial 3.0 and newer,
we add some version detection for the Mercurial version. This should
have been done months ago. We now have it.

I also took the opportunity to inform |mach bootstrap| that Mercurial
2.x is no longer modern.

I also updated the messaging around mq to encourage fewer new users to
use it. You may find this controversial. People can always ignore the
message.

Finally, I also added a histedit prompt to the mix, since a lot of
people don't know about that and many find it useful.

I could have broken this into multiple patches. Meh.

Comment 2

[Steven MacLeod [:smacleod]]

Comment on attachment 8449729 [details] [diff] [review]
Add reviewboard to mach mercurial-setup; version checking

Review of attachment 8449729 [details] [diff] [review]:
-----------------------------------------------------------------

All looks fine to me.

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/fx-team/rev/9ca6e87839f3

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9ca6e87839f3