Update Task API to include the newly added fields to Task model

VERIFIED FIXED in Milestone 2

Status

VERIFIED FIXED
4 years ago
7 days ago

People

(Reporter: bitgeeky, Assigned: bitgeeky)

Tracking

Version 2
Milestone 2
x86_64
Linux

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This bug is to add the newly added fields (project, team, type, difficulty, keywords, repeatable, why_this_matters) to the Task REST API
(Assignee)

Updated

4 years ago
Assignee: nobody → mozpankaj1994
(Assignee)

Comment 1

4 years ago
Created attachment 8450100 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/149

Supports task creation with newly added fields and keywords.
Attachment #8450100 - Flags: review?(bob.silverberg)
Comment on attachment 8450100 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/149

Good start, bitgeeky. Just a couple of changes needed, and also add unit tests.
Attachment #8450100 - Flags: review?(bob.silverberg) → review-
(Assignee)

Comment 3

4 years ago
Comment on attachment 8450100 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/149

I added a new commit, but having some problem with the test to delete task. Although deletion works fine when requested using request.delete() but in the test I am always getting 403 error, which says that user doesn't has sufficient permissions to delete task, but I am making the client  user a super user before the test runs, so this error shouldn't be there. Also task creation works really fine.

There is some problem with Factories that I am not able to figure out. Could you please help me here.
Flags: needinfo?(bob.silverberg)
Bitgeeky: I'm going to be out of town until Monday, so won't be able to be of much help with this until then. If you cannot make progress on it move onto something else. I believe that there are still existing tests that are failing and those should be prioritized over this anyway.

I have a couple of general suggestions for this though:

1. Compare the test you have, and that is working, for the User deletion API to this one to try to figure out why that's working and this isn't.
2. If you think it may be an issue with the task factories, perhaps try creating a task via the task API instead of via the factory and then try deleting that task during the test.
Flags: needinfo?(bob.silverberg)
(Assignee)

Comment 5

4 years ago
Comment on attachment 8450100 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/149

Figured it out ! 

There was a problem with the user who creates the task, the user who creates the task must have the permission to create it, so it was mandatory to pass creator as an argument while creating a task using TaskFactory().

Everything works fine now and all the tests pass !
Attachment #8450100 - Flags: review- → review?(bob.silverberg)
Comment on attachment 8450100 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/149

Great work, bitgeeky. It just needs a bit of cleanup and some enhancements to the unit tests.
Attachment #8450100 - Flags: review?(bob.silverberg) → review-
(Assignee)

Comment 7

4 years ago
Comment on attachment 8450100 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/149

Made the suggested changes. Please review.
Attachment #8450100 - Flags: review- → review?(bob.silverberg)
Comment on attachment 8450100 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/149

Very close. Just a couple of changes to the tests, and a request for a bit more investigation.
Attachment #8450100 - Flags: review?(bob.silverberg) → review-
Target Milestone: --- → Milestone 2
(Assignee)

Comment 9

4 years ago
Comment on attachment 8450100 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/149

Made the suggested changes. Please review.
Attachment #8450100 - Flags: review- → review?(bob.silverberg)
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Please add verification steps or add "qa-" to the whiteboard. Thanks
Whiteboard: [qa-]
Verifying as [qa-]
Status: RESOLVED → VERIFIED

Updated

7 days ago
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.