Closed
Bug 1033668
Opened 11 years ago
Closed 10 years ago
[FxAccounts] fix bottom buttons UI
Categories
(Firefox OS Graveyard :: FxA, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: arnau, Assigned: jhirsch)
Details
Attachments
(1 file)
46 bytes,
patch
|
jgruen
:
ui-review+
fcampo
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → rnowmrch
Reporter | ||
Comment 1•11 years ago
|
||
Attachment #8450024 -
Flags: ui-review?(jgruen)
Attachment #8450024 -
Flags: review?(fernando.campo)
Comment 2•11 years ago
|
||
Comment on attachment 8450024 [details] [diff] [review]
patch in github
Code looks nice, but I just realised this is not the part inside FTU, but the proper FxAccounts, and I'm not a peer on that module.
Hope someone from there can review it.
Attachment #8450024 -
Flags: review?(fernando.campo) → feedback+
Assignee | ||
Comment 3•11 years ago
|
||
I just saw this. Did you want to land this for 2.0? Are you still seeing the bug on master?
If you could attach before/after screenshots, I'd like to run any changes past UX quickly before going further.
Assignee: rnowmrch → 6a68
Flags: needinfo?(rnowmrch)
Comment 4•11 years ago
|
||
Currently there is no issue in 2.0 about bottom ui not showing with lack of screen space, if that's what this patch fixes, so perhaps we don't need to land this to 2.0 branch?
Assignee | ||
Comment 5•10 years ago
|
||
This bug has been sitting for a rather long time.
Closing as INVALID, as I haven't seen this problem with the buttons in quite a while, and QA hasn't reported it either.
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(rnowmrch)
Resolution: --- → INVALID
Comment 6•7 years ago
|
||
Comment on attachment 8450024 [details] [diff] [review]
patch in github
Review of attachment 8450024 [details] [diff] [review]:
-----------------------------------------------------------------
This is obviously a "lost to history" bug. R+ing to clean my Bugzilla dashboard
Attachment #8450024 -
Attachment is patch: true
Attachment #8450024 -
Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8450024 -
Flags: ui-review?(jgruen) → ui-review+
You need to log in
before you can comment on or make changes to this bug.
Description
•