Cleanup nfc_utils.js, review and add unit tests if necessary, add jsdoc's.

RESOLVED FIXED in 2.1 S1 (1aug)

Status

Firefox OS
Gaia::System
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kamituel, Assigned: kamituel)

Tracking

unspecified
2.1 S1 (1aug)
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
snowmantw
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
nfc_utils.js needs some attention:
- cleanup the code a bit
- review unit tests (and add some, if needed)
- use jsdoc comments
(Assignee)

Updated

4 years ago
Blocks: 933640
(Assignee)

Comment 1

4 years ago
Created attachment 8463877 [details] [review]
Pull request

Cleanup:
- unit tests
- comments
- removed unused methods
Attachment #8463877 - Flags: review?(gweng)
Comment on attachment 8463877 [details] [review]
Pull request

I think it's nice, and thanks for you to make code more clear.
Attachment #8463877 - Flags: review?(gweng) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
master: https://github.com/mozilla-b2g/gaia/commit/d56c7657a6a69b6b53d69a173dd0fe7c9d776a95
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)
also had to backout the part that didn't belong to the pull request in https://github.com/mozilla-b2g/gaia/commit/19095b8e939b3ffc04ace8075bab000007789024
You need to log in before you can comment on or make changes to this bug.