nfc_utils.js needs some attention: - cleanup the code a bit - review unit tests (and add some, if needed) - use jsdoc comments
Created attachment 8463877 [details] [review] Pull request Cleanup: - unit tests - comments - removed unused methods
Attachment #8463877 - Flags: review?(gweng)
Comment on attachment 8463877 [details] [review] Pull request I think it's nice, and thanks for you to make code more clear.
Attachment #8463877 - Flags: review?(gweng) → review+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)
also had to backout the part that didn't belong to the pull request in https://github.com/mozilla-b2g/gaia/commit/19095b8e939b3ffc04ace8075bab000007789024
You need to log in before you can comment on or make changes to this bug.