Closed
Bug 1033695
Opened 10 years ago
Closed 10 years ago
Cleanup nfc_utils.js, review and add unit tests if necessary, add jsdoc's.
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S1 (1aug)
People
(Reporter: kamituel, Assigned: kamituel)
References
Details
Attachments
(1 file)
nfc_utils.js needs some attention: - cleanup the code a bit - review unit tests (and add some, if needed) - use jsdoc comments
|
Assignee | |
Comment 1•10 years ago
|
||
Cleanup: - unit tests - comments - removed unused methods
Attachment #8463877 -
Flags: review?(gweng)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8463877 [details] [review] Pull request I think it's nice, and thanks for you to make code more clear.
Attachment #8463877 -
Flags: review?(gweng) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/d56c7657a6a69b6b53d69a173dd0fe7c9d776a95
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)
|
|
||
Comment 4•10 years ago
|
||
also had to backout the part that didn't belong to the pull request in https://github.com/mozilla-b2g/gaia/commit/19095b8e939b3ffc04ace8075bab000007789024
You need to log in
before you can comment on or make changes to this bug.
Description
•