Closed Bug 1033697 Opened 6 years ago Closed 6 years ago

Cleanup XPCConvert::NativeInterface2JSObject a bit

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(2 files)

No description provided.
Earlier in the function, there is an always-returning branch if |flat| is
non-null, so this code is only reached with a null |flat|, and the removed
code is dead.
Attachment #8449779 - Flags: review?(bobbyholley)
There is no good reason to keep the additional local variable, especially
because it is only used inside this branch.
Attachment #8449780 - Flags: review?(bobbyholley)
Attachment #8449779 - Flags: review?(bobbyholley) → review+
Attachment #8449780 - Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/mozilla-central/rev/a481b4bc3ae6
https://hg.mozilla.org/mozilla-central/rev/1cea3e0939e2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.