1033705 - Show compatibility warning if an add-on uses the browser.tabs.closeButtons preference

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 865826, the browser.tabs.closeButtons preference was removed. We need to flag all instances of this being used and show a warning.

This is a compatibility warning, so the add-on should still be upgraded in this case. It should also appear as a warning in regular validations.

Message:

The browser.tabs.closeButtons preference has been removed. See <LINK> for more information.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=865826

Affected add-on:

https://addons.mozilla.org/addon/tab-mix-plus/

Comment 1

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/amo-validator/pull/234

Comment 2

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/amo-validator/commit/c334e7cb534ca9f275576d06c173bd58c75e453e

Comment 3

[krupa raj[:krupa]]

verified fixed at https://addons.allizom.org/en-US/developers/upload/fdba53ec7b544b1fb742902c8d39550b

Comment 4

[Tony Mechelynck [:tonymec]]

FWIW, browser.tabs.closeButtons has a default (3 = at the end of the tab bar) in SeaMonkey, and there is an open bug (bug 534221, currently ASSIGNED to Philip Chee) to make it work.