1033822 - Remove old browser-chrome code from the Marionette runner

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

gps found some embarrassingly old and unused code in the Marionette runner dealing with the browser-chrome style tests we used to run for Gaia, but which have been obsolete for at least 2 years.

We should remove this code with extreme prejudice.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Remove unused browser-chrome code from Marionette,

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8452491 [details] [diff] [review]
Remove unused browser-chrome code from Marionette,

Review of attachment 8452491 [details] [diff] [review]:
-----------------------------------------------------------------

This is prejudice I can approve of!

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8452491 [details] [diff] [review]
Remove unused browser-chrome code from Marionette,

Review of attachment 8452491 [details] [diff] [review]:
-----------------------------------------------------------------

oops, I was a bit too excited to remove this. There's one missing change that should be in this patch: remove the 'browser_' case in https://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/runner/base.py#716.

Other than that, yes ship it!

Comment 4

[Jonathan Griffin (:jgriffin)]

Thanks for the catch.

Comment 5

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/40d096f86523

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/40d096f86523