1033853 - Unsaved files changes disappear when switching files in editor

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Fred Wenzel [:wenzel]]

STR:
- Start a new project from template
- click on manifest.webapp
- edit the name, but do not save
- click on a different file
- note: there's a * next to manifest.webapp to indicate it has unsaved changes
- click on manifest.webapp again

Actual:
- WebIDE reloads the file from disk (?), vaporizing your changes

Expected:
- though unsaved, merely clicking between different files to edit should not squash your edits.

Comment 1

[Paul Rouget [:paul]]

Brian, I'm pretty sure this used to work. Must be a regression. Not sure if it's an itchpad or webide issue. Can you take a look?

Comment 2

[Brian Grinstead [:bgrins]]

It's currently reloading files each time it is opened.  We could not do so if the file has changes.

When we have file watching set up we could handle the case more gracefully, by only reloading if the file has changed and to also prompt the user if the file has changed both on disk and in the editor.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: changed-files-reload.patch

Comment 4

[Heather Arthur [:harth]]

Comment on attachment 8451649 [details] [diff] [review]
changed-files-reload.patch

Review of attachment 8451649 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Brian Grinstead [:bgrins]]

https://tbpl.mozilla.org/?tree=Try&rev=ed806d6d7095

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/5b292bea616f

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/5b292bea616f

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5b292bea616f