1033883 - add nsAString_internal::Assign to prefix skiplist

Status: RESOLVED FIXED

(Socorro :: Infra, task)

Description

[Makoto Kato [:m_kato]]

This is OOM crash by nsAString_internal::Assign(nsAString_internal const&).

https://crash-stats.mozilla.com/report/list?signature=OOM+|+large+|+NS_ABORT_OOM%28unsigned+int%29+|+nsAString_internal%3A%3AAssign%28nsAString_internal+const%26%29&product=Firefox&query_type=contains&range_unit=weeks&process_type=any&hang_type=any&date=2014-07-02+09%3A00%3A00&range_value=1#tab-reports

The reason of OOM is that caller tries to assgin to big string.  So it should be separated by caller.  So, We should add nsAString_internal::Assign(nsAString_internal const&) to skip list.

Comment 1

[Lars Gusowski [:lagu]]

could we add the crash signature, that the crashes are linked in the crash-stats to this bug?
I didn't found the way to add the crash-signature.
Probably i doesn't have enough access for that.

Comment 2

[Lars Gusowski [:lagu]]

It isn't a Windows 8.1 problem, as filled in the meta-data.
Most crashes are on Windows 7.
The crashes happend in all windows Versions from xp - 8.1 and on Linux to.

Comment 3

[Makoto Kato [:m_kato]]

Bug 1027163 - bp-38ee56df-3623-48d2-879d-cea252140625
signature is [@ OOM | large | NS_ABORT_OOM(unsigned int) | nsAString_internal::Assign(nsAString_internal const&) ].  But this was fixed by bug 1027163.

But bp-d1c4a3a8-5aa1-4255-b538-72b272140702 is same signature, but this is another OOM issue.

If  nsAString_internal::Assign is added to skiplist, both crash id will be separated as another signature.

Comment 4

[Robert Kaiser]

IIRC, we discard the brackets in the algorithm anyhow, so it's nsAString_internal::Assign that needs to be added to the prefix skiplist.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/7a99bb8dbf76f7f5dcb656c3c2c2427383e25308
Merge pull request #2486 from twobraids/sig-round-up

fixes bug 1033883, bug 1017044, bug 902342, bug 1096757, bug 1092205: added lots of prefix signatures