1033951 - [Settings] Allow Settings app embed a app in its own process

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

This bug could be seen as the first step of resolving bug 1020063. We should provide a way of embedding another app in settings app. Before nested oop (bug 1020135) completes this cannot be utilized by 3rd-party apps. However, once bug 1020135 lands, it should be easy to embed the app out of process by adding the remote attribute.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8450067 [details] [review]
patch on master

Hi Arthur,

can you help me review this patch ?! Thanks :)

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8450067 [details] [review]
patch on master

Thank you for the patch, EJ. I've left a few comments regarding the naming and comments. Please also add test cases ensuring it navigates to the iframe panel correctly when passing a app url.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8450067 [details] [review]
patch on master

Hi Arthur,

I just added tests and addressed your comments ! Please help me take a took again when you have time. Big thanks !

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8450067 [details] [review]
patch on master

r=me, thank you!

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, this patch was landed on Gaia/master : https://github.com/mozilla-b2g/gaia/commit/20c6f80f9b708b23f3ae9b91089da810c3e0f4f7