[Settings] Allow Settings app embed a app in its own process

RESOLVED FIXED in 2.1 S1 (1aug)

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: arthurcc, Assigned: eragonj)

Tracking

unspecified
2.1 S1 (1aug)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=2])

Attachments

(1 attachment)

This bug could be seen as the first step of resolving bug 1020063. We should provide a way of embedding another app in settings app. Before nested oop (bug 1020135) completes this cannot be utilized by 3rd-party apps. However, once bug 1020135 lands, it should be easy to embed the app out of process by adding the remote attribute.
Comment on attachment 8450067 [details] [review]
patch on master

Hi Arthur,

can you help me review this patch ?! Thanks :)
Attachment #8450067 - Flags: review?(arthur.chen)
Comment on attachment 8450067 [details] [review]
patch on master

Thank you for the patch, EJ. I've left a few comments regarding the naming and comments. Please also add test cases ensuring it navigates to the iframe panel correctly when passing a app url.
Attachment #8450067 - Flags: review?(arthur.chen)
Comment on attachment 8450067 [details] [review]
patch on master

Hi Arthur,

I just added tests and addressed your comments ! Please help me take a took again when you have time. Big thanks !
Attachment #8450067 - Flags: review?(arthur.chen)
Whiteboard: [p=2]
Target Milestone: --- → 2.1 S1 (1aug)
Comment on attachment 8450067 [details] [review]
patch on master

r=me, thank you!
Attachment #8450067 - Flags: review?(arthur.chen) → review+
Thanks all, this patch was landed on Gaia/master : https://github.com/mozilla-b2g/gaia/commit/20c6f80f9b708b23f3ae9b91089da810c3e0f4f7
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.