1033988 - Remove workarounds for obsolete server parameters after production is updated

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Bug 1032741 is adding a workaround for allowing old versions of parameters. Once the server is updated, we should remove them. See the dependent bugs, the bits to change will be tagged with this bug number.

Comment 1

[Mark Banner (:standard8)]

Attachment: Remove workaround for old-style parameter when getting a call url from the Loop server

We can remove this now. Tests were updated for the new parameter in bug 1032741.

Comment 2

[Mark Banner (:standard8)]

Attachment: Remove workaround for old-style parameter when getting a call url from the Loop server

Updated to remove extra instances that I think should have been unnecessary, but were added recently. Bug 1045569 is going to handle the issue I mentioned on irc.

Comment 3

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8463965 [details] [diff] [review]
Remove workaround for old-style parameter when getting a call url from the Loop server

Review of attachment 8463965 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks good, r=me.

I'm surprised by the differences with compiled jsx files. We should file a bug to at least get consistent formatting for these.

Comment 4

[Mark Banner (:standard8)]

(In reply to Nicolas Perriault (:NiKo`) from comment #3)
> I'm surprised by the differences with compiled jsx files. We should file a
> bug to at least get consistent formatting for these.

Filed bug 1045690.

https://hg.mozilla.org/integration/mozilla-inbound/rev/7eb18ddea680

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7eb18ddea680