Closed
Bug 1033998
Opened 10 years ago
Closed 10 years ago
Reduce log spam from camera code on KK
Categories
(Core Graveyard :: Widget: Gonk, defect)
Tracking
(blocking-b2g:-, firefox31 wontfix, firefox32 fixed, firefox33 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)
People
(Reporter: mwu, Assigned: mwu)
References
Details
Attachments
(1 file)
45.15 KB,
patch
|
sotaro
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
This patch switches to standard android logging macros and makes sure logging is disabled by default. Logging can be reenabled by setting LOG_NDEBUG in the directory.
Attachment #8450098 -
Flags: review?(sotaro.ikeda.g)
Comment 1•10 years ago
|
||
Comment on attachment 8450098 [details] [diff] [review] Reduce camera log spam on KK Review of attachment 8450098 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thansk!
Attachment #8450098 -
Flags: review?(sotaro.ikeda.g) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/24ebcda3b781
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/24ebcda3b781
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Can we make sure to land this on 2.0 as well
blocking-b2g: --- → 2.0?
Comment 6•10 years ago
|
||
(In reply to bhargavg1 from comment #5) > Can we make sure to land this on 2.0 as well We can get this uplifted via approval in 2.0, no reason to block here. Blocking flag is used for release blocking issues typically
blocking-b2g: 2.0? → -
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8450098 [details] [diff] [review] Reduce camera log spam on KK Approval Request Comment [Feature/regressing bug #]: Bug 959505 (Camera support on gonk-kk) [User impact if declined]: Logging on gonk-kk is unusable with the camera on. [Describe test coverage new/current, TBPL]: [Risks and why]: Minimal - logging only change. [String/UUID change made/needed]: None
Attachment #8450098 -
Flags: approval-mozilla-aurora?
Flags: needinfo?(mwu)
Comment 9•10 years ago
|
||
Comment on attachment 8450098 [details] [diff] [review] Reduce camera log spam on KK Aurora+
Attachment #8450098 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/94b82dd392bf
status-b2g-v2.0:
--- → fixed
status-b2g-v2.1:
--- → fixed
status-firefox31:
--- → wontfix
status-firefox32:
--- → fixed
status-firefox33:
--- → fixed
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•