Closed
Bug 1034004
Opened 11 years ago
Closed 11 years ago
A promise chain failed to handle rejection in test browser_ruleview_completion-new-property_02.js
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: pbro, Assigned: pbro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
browser_ruleview_completion-new-property_02.js
Assignee | ||
Comment 1•11 years ago
|
||
Reported in this try build logs: https://tbpl.mozilla.org/php/getParsedLog.php?id=42847190&tree=Try&full=1
Like most of the failures reported there, it's not reported on the right test:
browser_ruleview_content_01.js | A promise chain failed to handle a rejection - unknownError ==> Is in fact a unhandled rejected promise from the previous test: browser_ruleview_completion-new-property_02.js but reported late in browser_ruleview_content_01.js.
I've been fixing a few similar bugs in the past days and one of the fix actually helped get rid of this one (probably due to bug 1026395 or bug 1026392).
Still this test modifies properties of the test element's inline style, which should be changed to a stylesheet rule instead to avoid triggering markup mutations during the test.
Assignee: nobody → pbrosset
Blocks: 1018184
Assignee | ||
Comment 2•11 years ago
|
||
Pending try build: https://tbpl.mozilla.org/?tree=Try&rev=4daa01469320
Attachment #8450109 -
Flags: review?(bgrinstead)
Comment 3•11 years ago
|
||
Comment on attachment 8450109 [details] [diff] [review]
bug1034004-unhandled-rejected-promise-browser_ruleview_completion-new-property_02.js.patch
Review of attachment 8450109 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine if it gets rid of the rejection. I can't help but think that we need to find a better generic solution for this (which seems to be something like markup mutations arriving late, after the document has changed). Because this could surely also happen during normal toolbox usage. Regardless, the change is fine with me.
Attachment #8450109 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Green try. Pushed to fx-team: https://hg.mozilla.org/integration/fx-team/rev/d9d1653a0f01
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•