[UI] Alert Manager needs a new page to view expired alerts

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jmaher, Assigned: kaustabh93, Mentored)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [next_bug][lang=javascript])

(Reporter)

Description

4 years ago
Once an alert is in the system, it usually comes in on the nightly branch and works through aurora, beta, and finally release.  Once we have released the code, there is no need to have tracked alerts.  It would be nice to mark alerts as a status of 'shipped' if they are not resolved and we have released the code.  

We can build a new webpage called expired.html which will  view all alerts that are not matching a status of 'resolved' or 'shipped' (probably more status TBD).  This way we can manually go in and verify/followup/etc.  Ideally we would have all expired alerts resolved/shipped after we have done uplifts and releases.

Here is what the UI looks like in production:
http://54.215.155.53:8080/alerts.html

To see what alert manager does and how to get started, here is a good place to start:
https://wiki.mozilla.org/Auto-tools/Projects/AlertManager

Please ask questions in this bug or on irc!
(Assignee)

Comment 1

4 years ago
Hi,
    I would like to take this on. 

Thanks.
(Assignee)

Comment 2

4 years ago
A bit of a clarification : All alerts which are not Resolved or Shipped should be listed

That means alerts with all these statuses are to be shown : NEW, Back Filling, Investigating, Duplicate, Wont Fix, False Alarm, Ignore, Not Tracking, Backout, Too Low.

Am I right?

Thanks.
(Reporter)

Comment 3

4 years ago
for the status list, I have been adding things to it arbitrarily as needed:
https://github.com/jmaher/alert_manager/blob/master/alerts.html#L222

We really should split that into two groups:
visible = [new, back filling, investigating]
hidden = [duplicate, won't fix, false alarm, ignore, not tracking, backout, too low, resolved, infra, shipped]
^ note, we would need to add 'shipped' to the list

Then if we have a new status for visible, we can keep it in context!
(Assignee)

Comment 4

4 years ago
Hi,
    I have created a file expired.html. Please do have a look at it.

Thanks.
(Assignee)

Comment 5

4 years ago
Hi,
I have added the alerts.js & simplified the alerts.html & expired.html. Please do have a look. And one more thing. Do I need to keep the 'Show All' checked at all time in the expired.html? If yes, then I need to add a small condition check.

Please do let me know of the results.

Thanks.
(Reporter)

Comment 6

4 years ago
To finish this bug, we should ensure that we only look at alerts > 18 weeks old (126 days).  Also the showAll=1 state should be set so we can see all alerts.  Maybe once we see this it will be too hard to manage- we will cross that bridge when we get there!
(Assignee)

Comment 7

4 years ago
Hi,
   I have solved this. Now should I attach the files here or mail them to you? I already have a pending pull request for the report.html. So I don't think it's a good idea to commit this to github now, is it?

Thanks.
(Reporter)

Comment 8

4 years ago
almost working, please check out the error in the firefox console here:
http://54.215.155.53:8080/expired.html
(Reporter)

Comment 9

4 years ago
we have fixed this and it is in production!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Updated

4 years ago
Assignee: nobody → kaustabh93
You need to log in before you can comment on or make changes to this bug.