Closed Bug 1034127 Opened 8 years ago Closed 5 years ago

Link error: unresolved external symbols in updater.exe with --enable-metro

Categories

(Firefox for Metro Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: alessarik, Unassigned)

References

Details

(Keywords: regression)

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131205075310

Steps to reproduce:

After adding options --enable-metro builds cannot be build on try servers.

In other words this option breaks build FieFox.


Actual results:

https://tbpl.mozilla.org/?tree=Try&rev=a2cbc9afcdf7

updater.exe
c:/builds/moz2_slave/try-w32-0000000000000000000000/build/obj-firefox/_virtualenv/Scripts/python.exe c:/builds/moz2_slave/try-w32-0000000000000000000000/build/config/expandlibs_exec.py --depend .deps/updater.exe.pp --target updater.exe --uselist -- link -NOLOGO -OUT:updater.exe -PDB:updater.pdb -ENTRY:wmainCRTStartup -SUBSYSTEM:WINDOWS -LARGEADDRESSAWARE -NXCOMPAT -RELEASE -DYNAMICBASE -SAFESEH  -DEBUG -DEBUGTYPE:CV -DEBUG -OPT:REF -DELAYLOAD:crypt32.dll -DELAYLOAD:userenv.dll -DELAYLOAD:wsock32.dll     archivereader.obj bspatch.obj updater.obj loaddlls.obj progressui_win.obj win_dirent.obj ./module.res kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib secur32.lib netapi32.lib ../common-standalone/updatecommon-standalone.lib ../../../../modules/libmar/src/mar.lib ../../../../modules/libbz2/src/bz2.lib  ../../../../modules/libmar/verify/verifymar.lib crypt32.lib advapi32.lib kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib secur32.lib netapi32.lib comctl32.lib ws2_32.lib shell32.lib shlwapi.lib delayimp.lib
c:/builds/moz2_slave/try-w32-0000000000000000000000/build/config/rules.mk:714: recipe for target 'updater.exe' failed
mozmake.exe[5]: Leaving directory 'c:/builds/moz2_slave/try-w32-0000000000000000000000/build/obj-firefox/toolkit/mozapps/update/updater'
c:/builds/moz2_slave/try-w32-0000000000000000000000/build/config/recurse.mk:95: recipe for target 'toolkit/mozapps/update/updater/libs' failed
mozmake.exe[4]: Leaving directory 'c:/builds/moz2_slave/try-w32-0000000000000000000000/build/obj-firefox'
c:/builds/moz2_slave/try-w32-0000000000000000000000/build/config/recurse.mk:39: recipe for target 'libs' failed
mozmake.exe[3]: Leaving directory 'c:/builds/moz2_slave/try-w32-0000000000000000000000/build/obj-firefox'
c:/builds/moz2_slave/try-w32-0000000000000000000000/build/config/rules.mk:577: recipe for target 'default' failed
mozmake.exe[2]: Leaving directory 'c:/builds/moz2_slave/try-w32-0000000000000000000000/build/obj-firefox'
c:/builds/moz2_slave/try-w32-0000000000000000000000/build/client.mk:393: recipe for target 'realbuild' failed
mozmake.exe[1]: Leaving directory 'c:/builds/moz2_slave/try-w32-0000000000000000000000/build'
client.mk:180: recipe for target 'build' failed
Executing: link -NOLOGO -OUT:updater.exe -PDB:updater.pdb -ENTRY:wmainCRTStartup -SUBSYSTEM:WINDOWS -LARGEADDRESSAWARE -NXCOMPAT -RELEASE -DYNAMICBASE -SAFESEH -DEBUG -DEBUGTYPE:CV -DEBUG -OPT:REF -DELAYLOAD:crypt32.dll -DELAYLOAD:userenv.dll -DELAYLOAD:wsock32.dll @c:\builds\moz2_slave\try-w32-0000000000000000000000\build\obj-firefox\toolkit\mozapps\update\updater\tmpxrsh34.list module.res kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib secur32.lib netapi32.lib crypt32.lib advapi32.lib kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib secur32.lib netapi32.lib comctl32.lib ws2_32.lib shell32.lib shlwapi.lib delayimp.lib
c:\builds\moz2_slave\try-w32-0000000000000000000000\build\obj-firefox\toolkit\mozapps\update\updater\tmpxrsh34.list:
    archivereader.obj
    bspatch.obj
    updater.obj
    loaddlls.obj
    progressui_win.obj
    win_dirent.obj
    ..\common-standalone\pathhash.obj
    ..\common-standalone\readstrings.obj
    ..\common-standalone\uachelper.obj
    ..\common-standalone\updatehelper.obj
    ..\common-standalone\updatelogging.obj
    ..\..\..\..\modules\libmar\src\Unified_c_modules_libmar_src0.obj
    ..\..\..\..\modules\libbz2\src\Unified_c_modules_libbz2_src0.obj
    ..\..\..\..\modules\libmar\verify\Unified_c_libmar_verify0.obj

updatehelper.obj : error LNK2019: unresolved external symbol __imp__CoAllowSetForegroundWindow@8 referenced in function "long __cdecl LaunchDefaultMetroBrowser(void)" (?LaunchDefaultMetroBrowser@@YAJXZ)

updatehelper.obj : error LNK2019: unresolved external symbol __imp__CoUninitialize@0 referenced in function "long __cdecl LaunchDefaultMetroBrowser(void)" (?LaunchDefaultMetroBrowser@@YAJXZ)

updatehelper.obj : error LNK2019: unresolved external symbol __imp__CoCreateInstance@20 referenced in function "long __cdecl LaunchDefaultMetroBrowser(void)" (?LaunchDefaultMetroBrowser@@YAJXZ)

updatehelper.obj : error LNK2019: unresolved external symbol __imp__CoInitialize@4 referenced in function "long __cdecl LaunchDefaultMetroBrowser(void)" (?LaunchDefaultMetroBrowser@@YAJXZ)

updater.exe : fatal error LNK1120: 4 unresolved externals


Expected results:

FireFox with Metro interface should be build correctly under Windows.
technically it doesn't have to build on mc, that's the reason we created the metro repo, so we test build mc and fix issues people break in the metro repo. We can also uplift fixes to mc if they don't break new mc features.

FWIW the metro repo built fine after the last mc merge I did a week or so ago.
Summary: MetroFF should builds on sources in mozilla-central → Link error: unresolved external symbols in updater.exe with --enable-metro
I suspect this is a regression from bug 1022847.  Does the --enable-metro build succeed with that patch reverted?

You could probably work around this problem by adding --disable-updater to your mozconfig.
Blocks: 1022847
Keywords: regression
After adding in config:
>+ac_add_options --enable-metro
>+ac_add_options --disable-updater
builds break with unknown issues:
  https://tbpl.mozilla.org/?tree=Try&rev=a4fc02a545a1
But in this case, I can download Metro FireFox.
Mass close of bugs in obsolete product https://bugzilla.mozilla.org/show_bug.cgi?id=1350354
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.