1034135 - Correct context handling in GeckoAppShell

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

Everywhere we use the app context in GeckoAppShell to do UI stuff, we should be using GeckoInterface's getActivity method.

We should be calling setGeckoInterface everywhere we create a new activity, just as we set the app context in GAS.

Additionally, because we support nested interfaces and activity re-entrancy, sGeckoInterface should really be a stack, and we should push and pop our activities onto it as they begin and end, so we don't leak.

Everywhere we use the GeckoInterface, we should check for null, and optionally decide to use FLAG_ACTIVITY_NEW_TASK.

Comment 1

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.